Skip to content

Commit 6a98b4e

Browse files
pluehnelarsxschneider
authored andcommitted
Make table chart type explicit (#150)
This adds an explicit chart type declaration to all tables. The benefit of this is that this enables users to implement custom table types (with a distinct chart type) in extensions without clashing with Hubble’s own table type.
1 parent bb29f3d commit 6a98b4e

11 files changed

+16
-10
lines changed

docs/assets/js/charts.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1070,6 +1070,11 @@ $(window).bind('load', function()
10701070
}
10711071
});
10721072

1073-
tables.each((index, table) => createTable(table));
1073+
tables.each(
1074+
function(index, table)
1075+
{
1076+
if ($(table).attr('data-type') == 'table')
1077+
createTable(table);
1078+
});
10741079
});
10751080
});

docs/housekeeping-abandoned-orgs.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,5 @@ <h3>Abandoned Organizations</h3>
5252
</div>
5353

5454
<div class="chart-placeholder">
55-
<table data-url="{{ site.dataURL }}/organizations-abandoned-detailed.tsv"></table>
55+
<table data-url="{{ site.dataURL }}/organizations-abandoned-detailed.tsv" data-type="table"></table>
5656
</div>

docs/housekeeping-api-requests.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ <h3>API Requests</h3>
5151
</div>
5252

5353
<div class="chart-placeholder">
54-
<table data-url="{{ site.dataURL }}/api-requests-detailed.tsv"></table>
54+
<table data-url="{{ site.dataURL }}/api-requests-detailed.tsv" data-type="table"></table>
5555
<div class="info-box">
5656
<p>
5757
This table lists the resources requested via the API that accounted for the majority of API requests yesterday.

docs/housekeeping-forks.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,5 @@ <h3>Forks to Organizations</h3>
5959
</div>
6060

6161
<div class="chart-placeholder">
62-
<table data-url="{{ site.dataURL }}/forks-to-organizations-detailed.tsv"></table>
62+
<table data-url="{{ site.dataURL }}/forks-to-organizations-detailed.tsv" data-type="table"></table>
6363
</div>

docs/housekeeping-git-requests.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ <h3>Git Requests</h3>
5151
</div>
5252

5353
<div class="chart-placeholder">
54-
<table data-url="{{ site.dataURL }}/git-requests-detailed.tsv"></table>
54+
<table data-url="{{ site.dataURL }}/git-requests-detailed.tsv" data-type="table"></table>
5555
<div class="info-box">
5656
<p>
5757
This table lists the repositories that accounted for the majority of Git requests yesterday.

docs/housekeeping-git-traffic.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ <h3>Transferred Data</h3>
129129
</div>
130130

131131
<div class="chart-placeholder">
132-
<table data-url="{{ site.dataURL }}/git-download-detailed.tsv"></table>
132+
<table data-url="{{ site.dataURL }}/git-download-detailed.tsv" data-type="table"></table>
133133
<div class="info-box">
134134
<p>
135135
This table lists the repositories that accounted for the majority of the traffic yesterday.

docs/housekeeping-repo-location.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ <h3>Personal Repositories with Nonowner Pushes (Last 4 Weeks)</h3>
5151
</div>
5252

5353
<div class="chart-placeholder">
54-
<table data-url="{{ site.dataURL }}/repositories-personal-nonowner-pushes-detailed.tsv"></table>
54+
<table data-url="{{ site.dataURL }}/repositories-personal-nonowner-pushes-detailed.tsv" data-type="table"></table>
5555
</div>

docs/org-owners.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<div class="chart-placeholder">
88
<h3>Organization Owners</h3>
9-
<table data-url="{{ site.dataURL }}/org-owners.tsv"></table>
9+
<table data-url="{{ site.dataURL }}/org-owners.tsv" data-type="table"></table>
1010
<div class="info-box">
1111
<p>Owners for each GitHub organization.</p>
1212
</div>

docs/recommendations-legacy-teams.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,5 @@ <h3>Legacy Admin Teams</h3>
5050
</div>
5151

5252
<div class="chart-placeholder">
53-
<table data-url="{{ site.dataURL }}/teams-legacy-detailed.tsv"></table>
53+
<table data-url="{{ site.dataURL }}/teams-legacy-detailed.tsv" data-type="table"></table>
5454
</div>

docs/recommendations-tokenless-auth.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,5 @@ <h3>Tokenless Authentication Requests</h3>
5858
</div>
5959

6060
<div class="chart-placeholder">
61-
<table data-url="{{ site.dataURL }}/tokenless-authentication-detailed.tsv"></table>
61+
<table data-url="{{ site.dataURL }}/tokenless-authentication-detailed.tsv" data-type="table"></table>
6262
</div>

docs/repos-activity.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ <h3>Most Active Repositories</h3>
8888
<table
8989
data-url="{{ site.dataURL }}/repository-activity-detailed.tsv"
9090
data-config='{"slice": [0, 50]}'
91+
data-type="table"
9192
></table>
9293
<div class="info-box">
9394
<p>The top 50 most active repositories by number of pushes.</p>

0 commit comments

Comments
 (0)