Skip to content

Commit 9133edc

Browse files
author
Soumya Mahunt
committed
docs(README): add limitations
1 parent d374edd commit 9133edc

File tree

8 files changed

+84
-18
lines changed

8 files changed

+84
-18
lines changed

.github/config/pre_changelog_hook.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ exports.preVersionGeneration = (version) => {
2121
const new_gem_info = gem_info.replace(/VERSION\s*=\s*.*/g, `VERSION = '${version}'.freeze`);
2222
core.info(`Updated gem info: ${new_gem_info}`);
2323
fs.writeFileSync(gem_info_file, new_gem_info);
24+
25+
const launchOption = { cwd: GITHUB_WORKSPACE };
26+
childProcess.execSync('bundle exec rake demo', launchOption);
2427
return version;
2528
}
2629

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ group :development do
1212
gem 'bacon'
1313
gem 'mocha-on-bacon'
1414
gem 'prettybacon'
15+
gem 'solargraph'
1516
end

Gemfile.lock

Lines changed: 57 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: .
33
specs:
4-
cocoapods-embed-flutter (0.5.1)
4+
cocoapods-embed-flutter (0.5.2)
55
cocoapods
66
fileutils
77
yaml
@@ -22,8 +22,11 @@ GEM
2222
algoliasearch (1.27.5)
2323
httpclient (~> 2.8, >= 2.8.3)
2424
json (>= 1.5.1)
25+
ast (2.4.2)
2526
atomos (0.1.3)
27+
backport (1.2.0)
2628
bacon (1.2.0)
29+
benchmark (0.2.0)
2730
claide (1.1.0)
2831
cocoapods (1.11.2)
2932
addressable (~> 2.8)
@@ -66,6 +69,8 @@ GEM
6669
concurrent-ruby (1.1.9)
6770
descendants_tracker (0.0.4)
6871
thread_safe (~> 0.3, >= 0.3.1)
72+
diff-lcs (1.5.0)
73+
e2mmap (0.1.0)
6974
escape (0.0.4)
7075
ethon (0.15.0)
7176
ffi (>= 1.15.0)
@@ -107,8 +112,13 @@ GEM
107112
httpclient (2.8.3)
108113
i18n (1.10.0)
109114
concurrent-ruby (~> 1.0)
115+
jaro_winkler (1.5.4)
110116
json (2.6.1)
111117
jwt (2.3.0)
118+
kramdown (2.3.1)
119+
rexml
120+
kramdown-parser-gfm (1.1.0)
121+
kramdown (~> 2.0)
112122
minitest (5.15.0)
113123
mocha (1.13.0)
114124
mocha-on-bacon (0.2.3)
@@ -120,25 +130,68 @@ GEM
120130
nanaimo (0.3.0)
121131
nap (1.1.0)
122132
netrc (0.11.0)
133+
nokogiri (1.13.3-arm64-darwin)
134+
racc (~> 1.4)
135+
nokogiri (1.13.3-x86_64-darwin)
136+
racc (~> 1.4)
123137
oauth2 (1.4.9)
124138
faraday (>= 0.17.3, < 3.0)
125139
jwt (>= 1.0, < 3.0)
126140
multi_json (~> 1.3)
127141
multi_xml (~> 0.5)
128142
rack (>= 1.2, < 3)
143+
parallel (1.21.0)
144+
parser (3.1.1.0)
145+
ast (~> 2.4.1)
129146
prettybacon (0.0.2)
130147
bacon (~> 1.2)
131148
public_suffix (4.0.6)
149+
racc (1.6.0)
132150
rack (2.2.3)
151+
rainbow (3.1.1)
133152
rake (13.0.6)
153+
regexp_parser (2.2.1)
154+
reverse_markdown (2.1.1)
155+
nokogiri
134156
rexml (3.2.5)
157+
rubocop (1.26.0)
158+
parallel (~> 1.10)
159+
parser (>= 3.1.0.0)
160+
rainbow (>= 2.2.2, < 4.0)
161+
regexp_parser (>= 1.8, < 3.0)
162+
rexml
163+
rubocop-ast (>= 1.16.0, < 2.0)
164+
ruby-progressbar (~> 1.7)
165+
unicode-display_width (>= 1.4.0, < 3.0)
166+
rubocop-ast (1.16.0)
167+
parser (>= 3.1.1.0)
135168
ruby-macho (2.5.1)
169+
ruby-progressbar (1.11.0)
136170
ruby2_keywords (0.0.5)
171+
solargraph (0.44.3)
172+
backport (~> 1.2)
173+
benchmark
174+
bundler (>= 1.17.2)
175+
diff-lcs (~> 1.4)
176+
e2mmap
177+
jaro_winkler (~> 1.5)
178+
kramdown (~> 2.3)
179+
kramdown-parser-gfm (~> 1.1)
180+
parser (~> 3.0)
181+
reverse_markdown (>= 1.0.5, < 3)
182+
rubocop (>= 0.52)
183+
thor (~> 1.0)
184+
tilt (~> 2.0)
185+
yard (~> 0.9, >= 0.9.24)
186+
thor (1.2.1)
137187
thread_safe (0.3.6)
188+
tilt (2.0.10)
138189
typhoeus (1.4.0)
139190
ethon (>= 0.9.0)
140191
tzinfo (2.0.4)
141192
concurrent-ruby (~> 1.0)
193+
unicode-display_width (2.1.0)
194+
webrick (1.7.0)
142195
xcodeproj (1.21.0)
143196
CFPropertyList (>= 2.3.3, < 4.0)
144197
atomos (~> 0.1.3)
@@ -147,6 +200,8 @@ GEM
147200
nanaimo (~> 0.3.0)
148201
rexml (~> 3.2.4)
149202
yaml (0.2.0)
203+
yard (0.9.27)
204+
webrick (~> 1.7.0)
150205
zeitwerk (2.5.4)
151206

152207
PLATFORMS
@@ -165,6 +220,7 @@ DEPENDENCIES
165220
mocha-on-bacon
166221
prettybacon
167222
rake
223+
solargraph
168224

169225
BUNDLED WITH
170226
2.3.7

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@ pub 'flutter_module', :git => 'https://github.com/gowalla/flutter_module.git', :
4040
pub 'flutter_module', :git => 'https://github.com/gowalla/flutter_module.git', :commit => '082f8319af'
4141
```
4242

43+
## Limitations
44+
45+
- You won't be able to add more than one flutter module to a single target. Currently flutter only supports one module per target.
46+
- No caching is done for external sources, every time you run `pod install` flutter module will be downloaded each time.
47+
4348
## Links
4449

4550
| Link | Description |

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ end
1212
desc 'Setup example project'
1313
task :demo do
1414
system('bundle install', exception: true)
15-
Bundler.with_clean_env do
15+
Bundler.with_unbundled_env do
1616
Dir.chdir('example/ios_app') do |path|
1717
system('bundle install', exception: true)
1818
system('bundle exec pod install', exception: true)

cocoapods-embed-flutter.gemspec

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,28 +9,29 @@ Gem::Specification.new do |spec|
99

1010
spec.name = 'cocoapods-embed-flutter'
1111
spec.version = CocoapodsEmbedFlutter::VERSION
12-
spec.authors = ['Soumya Ranjan Mahunt']
13-
spec.email = ['devsoumyamahunt@gmail.com']
14-
spec.description = %q{Embed flutter modules in iOS projects.}
15-
spec.summary = <<-DESC
16-
Straight forward way of declaring flutter modules as dependency for targets,
17-
just like cocoapods does with pods.
18-
DESC
1912
spec.homepage = repo_url
2013
spec.license = 'MIT'
14+
spec.authors = ['Soumya Ranjan Mahunt']
15+
spec.email = ['devsoumyamahunt@gmail.com']
16+
spec.summary = %q{Embed flutter modules in iOS projects.}
17+
spec.description = <<-EOF
18+
Straight forward way of declaring flutter modules as dependency for targets,
19+
just like cocoapods does with pods.
20+
EOF
2121

22-
spec.files = `git ls-files`.split($/)
22+
spec.files = `git ls-files`.split($/).grep_v(%r{^(example|.github)/})
2323
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
2424
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
2525
spec.require_paths = ['lib']
2626

27-
spec.add_dependency 'yaml'
28-
spec.add_dependency 'fileutils'
29-
spec.add_dependency 'cocoapods'
27+
spec.add_runtime_dependency 'yaml'
28+
spec.add_runtime_dependency 'fileutils'
29+
spec.add_runtime_dependency 'cocoapods'
3030

3131
spec.add_development_dependency 'bundler'
3232
spec.add_development_dependency 'rake'
3333

34+
spec.required_ruby_version = '>= 2.6'
3435
spec.metadata = {
3536
'bug_tracker_uri' => "#{repo_url}/issues",
3637
'changelog_uri' => "#{repo_url}/blob/main/CHANGELOG.md",

example/ios_app/Gemfile.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: ../..
33
specs:
4-
cocoapods-embed-flutter (0.5.1)
4+
cocoapods-embed-flutter (0.5.2)
55
cocoapods
66
fileutils
77
yaml
@@ -24,10 +24,10 @@ GEM
2424
json (>= 1.5.1)
2525
atomos (0.1.3)
2626
claide (1.1.0)
27-
cocoapods (1.11.2)
27+
cocoapods (1.11.3)
2828
addressable (~> 2.8)
2929
claide (>= 1.0.2, < 2.0)
30-
cocoapods-core (= 1.11.2)
30+
cocoapods-core (= 1.11.3)
3131
cocoapods-deintegrate (>= 1.0.3, < 2.0)
3232
cocoapods-downloader (>= 1.4.0, < 2.0)
3333
cocoapods-plugins (>= 1.0.0, < 2.0)
@@ -42,7 +42,7 @@ GEM
4242
nap (~> 1.0)
4343
ruby-macho (>= 1.0, < 3.0)
4444
xcodeproj (>= 1.21.0, < 2.0)
45-
cocoapods-core (1.11.2)
45+
cocoapods-core (1.11.3)
4646
activesupport (>= 5.0, < 7)
4747
addressable (~> 2.8)
4848
algoliasearch (~> 1.0)

example/ios_app/Podfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ SPEC CHECKSUMS:
2525

2626
PODFILE CHECKSUM: 63b6421f4bf00554065d89d2308ed2deb78332fc
2727

28-
COCOAPODS: 1.11.2
28+
COCOAPODS: 1.11.3

0 commit comments

Comments
 (0)