Skip to content

Commit 8e1a5cc

Browse files
committed
Merge branch 'feature/SourceLink' into develop
Introduced Microsoft `SourceLink`, along with recommended configuration settings. Alongside the symbols package, this will help ensure that consumers of the NuGet packages will be able to step into OnTopic code during debugging by associating it with specific commits of specific files on GitHub. While I was at it, I also migrated from the deprecated `GitVersionTask` to `GitVersion.MsBuild`. This maintains feature parity, while giving us access to new builds going forward. I also reverted the previous update to the `GitVersion.yml`, which didn't behave as intended. Together, these improve our build process.
2 parents 0f071ff + e960130 commit 8e1a5cc

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

GitVersion.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@ mode: ContinuousDeployment
33
branches:
44
master:
55
mode: ContinuousDelivery
6-
release:
7-
mode: ContinuousDelivery
86
ignore:
97
sha: []

OnTopic.Data.Transfer/OnTopic.Data.Transfer.csproj

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717
<Copyright>©2021 Ignia, LLC</Copyright>
1818
<OutputPath>bin\$(Configuration)\</OutputPath>
1919
<Authors>Ignia</Authors>
20+
<NeutralLanguage>en</NeutralLanguage>
21+
<EmbedUntrackedSources>true</EmbedUntrackedSources>
22+
<IncludeSymbols>true</IncludeSymbols>
2023
</PropertyGroup>
2124

2225
<PropertyGroup>
@@ -29,8 +32,16 @@
2932
<NoWarn>1701;1702;CA2227</NoWarn>
3033
</PropertyGroup>
3134

35+
<PropertyGroup Condition="'$(TF_BUILD)' == 'true'">
36+
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
37+
</PropertyGroup>
38+
3239
<ItemGroup>
33-
<PackageReference Include="GitVersionTask" Version="5.5.1">
40+
<PackageReference Include="GitVersion.MsBuild" Version="5.6.6">
41+
<PrivateAssets>all</PrivateAssets>
42+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
43+
</PackageReference>
44+
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0">
3445
<PrivateAssets>all</PrivateAssets>
3546
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
3647
</PackageReference>

0 commit comments

Comments
 (0)