Rename AttributeValue to AttributeRecord

This aligns with the rename of `TrackedItem` to `TrackedRecord` (a6db252). This is a major breaking change, since `AttributeValue` is a long established class. That said, this avoids the awkward convention of e.g. `AttributeValue.Value`, and unifies the naming convention for combining metadata and values as a "Record".

(As it so happens, this also _happens_ to be a C# 9.0 record type—though that's not why we're using this naming convention here.)

Author: JeremyCaney

OnTopic.Data.Sql/Models/AttributeValuesDataTable.cs

@@ -38,7 +38,7 @@ internal AttributeValuesDataTable() {
       | COLUMN: Attribute Value
       \-----------------------------------------------------------------------------------------------------------------------*/
       Columns.Add(
-        new DataColumn("AttributeValue") {
+        new DataColumn("AttributeRecord") {
           MaxLength             = 255
         }
       );
@@ -51,16 +51,16 @@ internal AttributeValuesDataTable() {
     /// <summary>
     ///   Provides a convenience method for adding a new <see cref="DataRow"/> based on the expected column values.
     /// </summary>
-    /// <param name="attributeKey">The <see cref="AttributeValue.Key"/>.</param>
-    /// <param name="attributeValue">The <see cref="AttributeValue.Value"/>.</param>
+    /// <param name="attributeKey">The <see cref="AttributeRecord.Key"/>.</param>
+    /// <param name="attributeValue">The <see cref="AttributeRecord.Value"/>.</param>
     internal DataRow AddRow(string attributeKey, string? attributeValue = null) {
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Define record
       \-----------------------------------------------------------------------------------------------------------------------*/
       var record                = NewRow();
       record["AttributeKey"]    = attributeKey;
-      record["AttributeValue"]  = attributeValue;
+      record["AttributeRecord"]  = attributeValue;
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Add record

OnTopic.Data.Sql/SqlDataReaderExtensions.cs

@@ -237,7 +237,7 @@ private static void SetIndexedAttributes(this IDataReader reader, TopicIndex top
       \-----------------------------------------------------------------------------------------------------------------------*/
       var topicId               = reader.GetTopicId();
       var attributeKey          = reader.GetString("AttributeKey");
-      var attributeValue        = reader.GetString("AttributeValue");
+      var attributeValue        = reader.GetString("AttributeRecord");
       var version               = reader.GetVersion();
 
       /*------------------------------------------------------------------------------------------------------------------------

OnTopic.TestDoubles/StubTopicRepository.cs

@@ -139,7 +139,7 @@ protected override void DeleteTopic(Topic topic) { }
     | METHOD: GET ATTRIBUTES (PROXY)
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <inheritdoc cref="TopicRepository.GetAttributes(Topic, Boolean?, Boolean?)" />
-    public IEnumerable<AttributeValue> GetAttributesProxy(
+    public IEnumerable<AttributeRecord> GetAttributesProxy(
       Topic topic,
       bool? isExtendedAttribute,
       bool? isDirty = null,

OnTopic.Tests/AttributeValueCollectionTest.cs

@@ -317,7 +317,7 @@ public void Clear_ExistingValues_IsDirty() {
     | TEST: SET VALUE: VALUE UNCHANGED: IS NOT DIRTY?
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Sets the value of a custom <see cref="AttributeValue"/> to the existing value and ensures it is <i>not</i> marked as
+    ///   Sets the value of a custom <see cref="AttributeRecord"/> to the existing value and ensures it is <i>not</i> marked as
     ///   <see cref="TrackedRecord{T}.IsDirty"/>.
     /// </summary>
     [TestMethod]
@@ -336,7 +336,7 @@ public void SetValue_ValueUnchanged_IsNotDirty() {
     | TEST: IS DIRTY: DIRTY VALUES: RETURNS TRUE
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeValue"/> that is marked as <see
+    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeRecord"/> that is marked as <see
     ///   cref="TrackedRecord{T}.IsDirty"/>. Confirms that <see cref="AttributeValueCollection.IsDirty(Boolean)"/> returns
     ///   <c>true</c>.
     /// </summary>
@@ -355,7 +355,7 @@ public void IsDirty_DirtyValues_ReturnsTrue() {
     | TEST: IS DIRTY: DELETED VALUES: RETURNS TRUE
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeValue"/> and then deletes it. Confirms
+    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeRecord"/> and then deletes it. Confirms
     ///   that <see cref="AttributeValueCollection.IsDirty(Boolean)"/> returns <c>true</c>.
     /// </summary>
     [TestMethod]
@@ -374,7 +374,7 @@ public void IsDirty_DeletedValues_ReturnsTrue() {
     | TEST: IS DIRTY: NO DIRTY VALUES: RETURNS FALSE
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeValue"/> that is <i>not</i> marked as
+    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeRecord"/> that is <i>not</i> marked as
     ///   <see cref="TrackedRecord{T}.IsDirty"/>. Confirms that <see cref="AttributeValueCollection.IsDirty(Boolean)"/> returns
     ///   <c>false</c>/
     /// </summary>
@@ -393,8 +393,8 @@ public void IsDirty_NoDirtyValues_ReturnsFalse() {
     | TEST: IS DIRTY: EXCLUDE LAST MODIFIED: RETURNS FALSE
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeValue"/> that is <i>not</i> marked as
-    ///   <see cref="TrackedRecord{T}.IsDirty"/> as well as a <c>LastModified</c> <see cref="AttributeValue"/> that is. Confirms
+    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeRecord"/> that is <i>not</i> marked as
+    ///   <see cref="TrackedRecord{T}.IsDirty"/> as well as a <c>LastModified</c> <see cref="AttributeRecord"/> that is. Confirms
     ///   that <see cref="AttributeValueCollection.IsDirty(Boolean)"/> returns <c>false</c>.
     /// </summary>
     [TestMethod]
@@ -414,7 +414,7 @@ public void IsDirty_ExcludeLastModified_ReturnsFalse() {
     | TEST: IS DIRTY: MARK CLEAN: UPDATES LAST MODIFIED
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeValue"/> and then deletes it. Confirms
+    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeRecord"/> and then deletes it. Confirms
     ///   that the <see cref="TrackedRecord{T}.LastModified"/> returns the new <c>version</c> after calling <see cref="
     ///   TrackedRecordCollection{TItem, TValue, TAttribute}.MarkClean(DateTime?)"/>.
     /// </summary>
@@ -436,7 +436,7 @@ public void IsDirty_MarkClean_UpdatesLastModified() {
     | TEST: IS DIRTY: MARK CLEAN: RETURNS FALSE
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeValue"/> and then deletes it. Confirms
+    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeRecord"/> and then deletes it. Confirms
     ///   that <see cref="AttributeValueCollection.IsDirty(Boolean)"/> returns <c>false</c> after calling <see cref="
     ///   TrackedRecordCollection{TItem, TValue, TAttribute}.MarkClean(DateTime?)"/>.
     /// </summary>
@@ -460,7 +460,7 @@ public void IsDirty_MarkClean_ReturnsFalse() {
     | TEST: IS DIRTY: MARK ATTRIBUTE CLEAN: RETURNS FALSE
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeValue"/> and then confirms that <see
+    ///   Populates the <see cref="AttributeValueCollection"/> with a <see cref="AttributeRecord"/> and then confirms that <see
     ///   cref="TrackedRecordCollection{TItem, TValue, TAttribute}.IsDirty(String)"/> returns <c>false</c> for that attribute
     ///   after calling <see cref="TrackedRecordCollection{TItem, TValue, TAttribute}.MarkClean(String, DateTime?)"/>.
     /// </summary>
@@ -481,7 +481,7 @@ public void IsDirty_MarkAttributeClean_ReturnsFalse() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Populates a <see cref="AttributeValueCollection"/> associated with an <see cref="Topic.IsNew"/> <see cref="Topic"/>
-    ///   with a <see cref="AttributeValue"/> that is not marked as <see cref="TrackedRecord{T}.IsDirty"/> and then confirms
+    ///   with a <see cref="AttributeRecord"/> that is not marked as <see cref="TrackedRecord{T}.IsDirty"/> and then confirms
     ///   that <see cref="TrackedRecordCollection{TItem, TValue, TAttribute}.IsDirty()"/> returns <c>true</c>.
     /// </summary>
     [TestMethod]
@@ -506,7 +506,7 @@ public void IsDirty_AddCleanAttributeToNewTopic_ReturnsTrue() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Populates a <see cref="AttributeValueCollection"/> associated with an <see cref="Topic.IsNew"/> <see cref="Topic"/>
-    ///   with a <see cref="AttributeValue"/> and then confirms that <see cref="TrackedRecordCollection{TItem, TValue,
+    ///   with a <see cref="AttributeRecord"/> and then confirms that <see cref="TrackedRecordCollection{TItem, TValue,
     ///   TAttribute}.IsDirty(String)"/> returns <c>true</c> for that attribute after calling <see cref="TrackedRecordCollection
     ///   {TItem, TValue, TAttribute}.MarkClean(String, DateTime?)"/>.
     /// </summary>
@@ -542,7 +542,7 @@ public void SetValue_InvalidValue_ThrowsException() {
     | TEST: ADD: VALID ATTRIBUTE VALUE: IS RETURNED
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Sets a custom attribute on a topic by directly adding an <see cref="AttributeValue"/> instance; ensures it can be
+    ///   Sets a custom attribute on a topic by directly adding an <see cref="AttributeRecord"/> instance; ensures it can be
     ///   retrieved.
     /// </summary>
     [TestMethod]
@@ -669,7 +669,7 @@ public void Add_InvalidAttributeValue_ThrowsException() {
     | TEST: REPLACE VALUE: WITH BUSINESS LOGIC: MAINTAINS ISDIRTY
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Adds a new <see cref="AttributeValue"/> which maps to <see cref="Topic.Key"/> directly to a <see cref=
+    ///   Adds a new <see cref="AttributeRecord"/> which maps to <see cref="Topic.Key"/> directly to a <see cref=
     ///   "AttributeValueCollection"/> and confirms that the original <see cref="TrackedRecord{T}.IsDirty"/> is replaced if the
     ///   <see cref="TrackedRecord{T}.Value"/> changes.
     /// </summary>
@@ -683,7 +683,7 @@ public void Add_WithBusinessLogic_MaintainsIsDirty() {
 
       var index = topic.Attributes.IndexOf(originalValue);
 
-      topic.Attributes[index] = new AttributeValue("View", "NewValue", false);
+      topic.Attributes[index] = new AttributeRecord("View", "NewValue", false);
       topic.Attributes.TryGetValue("View", out var newAttribute);
 
       topic.Attributes.SetValue("View", "NewerValue", false);
@@ -699,7 +699,7 @@ public void Add_WithBusinessLogic_MaintainsIsDirty() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Adds a new attribute with an empty value, and confirms that it is <i>not</i> added as a new <see
-    ///   cref="AttributeValue"/>. Empty values are treated as the same as non-existent attributes. They are stored for the sake
+    ///   cref="AttributeRecord"/>. Empty values are treated as the same as non-existent attributes. They are stored for the sake
     ///   of tracking <i>deleted</i> attributes, but should not be stored for <i>new</i> attributes.
     /// </summary>
     [TestMethod]
@@ -718,7 +718,7 @@ public void SetValue_EmptyAttributeValue_Skips() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Adds a new attribute with an empty value, and confirms that it is <i>is</i> added as a new <see
-    ///   cref="AttributeValue"/> assuming the value previously existed. Empty values are treated as the same as non-existent
+    ///   cref="AttributeRecord"/> assuming the value previously existed. Empty values are treated as the same as non-existent
     ///   attributes, but they should be stored for the sake of tracking <i>deleted</i> attributes.
     /// </summary>
     [TestMethod]

OnTopic.Tests/Schemas/AttributesDataTable.cs

@@ -52,7 +52,7 @@ public AttributesDataTable() : base("Attributes") {
       \-----------------------------------------------------------------------------------------------------------------------*/
       Columns.Add(new DataColumn() {
         DataType                = typeof(string),
-        ColumnName              = "AttributeValue",
+        ColumnName              = "AttributeRecord",
         AllowDBNull             = true
       });
 
@@ -87,7 +87,7 @@ public void AddRow(int topicId, string attributeKey, string? attributeValue, Dat
 
       row["TopicId"]            = topicId;
       row["AttributeKey"]       = attributeKey;
-      row["AttributeValue"]     = attributeValue is null? DBNull.Value : attributeValue;
+      row["AttributeRecord"]     = attributeValue is null? DBNull.Value : attributeValue;
       row["Version"]            = version?? DateTime.UtcNow;
 
       /*------------------------------------------------------------------------------------------------------------------------

OnTopic.Tests/TopicRepositoryBaseTest.cs

@@ -219,7 +219,7 @@ public void GetAttributes_AnyAttributes_ReturnsAllAttributes() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Retrieves a list of attributes from a topic, without any filtering by whether or not the attribute is an <see
-    ///   cref="AttributeDescriptor.IsExtendedAttribute"/>. Any <see cref="AttributeValue"/>s with a null or empty value should
+    ///   cref="AttributeDescriptor.IsExtendedAttribute"/>. Any <see cref="AttributeRecord"/>s with a null or empty value should
     ///   be skipped.
     /// </summary>
     [TestMethod]
@@ -280,8 +280,8 @@ public void GetAttributes_ExtendedAttributes_ReturnsExtendedAttributes() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Retrieves a list of attributes from a topic, filtering by <see cref="TrackedRecord{T}.IsDirty"/>. Expects an <see
-    ///   cref="AttributeValue"/> to be returned even if it's <i>not</i> <see cref="TrackedRecord{T}.IsDirty"/> <i>but</i> its
-    ///   <see cref="AttributeValue.IsExtendedAttribute"/> disagrees with <see cref="AttributeDescriptor.IsExtendedAttribute"/>.
+    ///   cref="AttributeRecord"/> to be returned even if it's <i>not</i> <see cref="TrackedRecord{T}.IsDirty"/> <i>but</i> its
+    ///   <see cref="AttributeRecord.IsExtendedAttribute"/> disagrees with <see cref="AttributeDescriptor.IsExtendedAttribute"/>.
     /// </summary>
     [TestMethod]
     public void GetAttributes_ExtendedAttributeMismatch_ReturnsExtendedAttributes() {
@@ -302,7 +302,7 @@ public void GetAttributes_ExtendedAttributeMismatch_ReturnsExtendedAttributes()
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Retrieves a list of attributes from a topic, filtering by <see cref="TrackedRecord{T}.IsDirty"/>. Expects the <see
-    ///   cref="AttributeValue"/> to <i>not</i> be returned even though its <see cref="AttributeValue.IsExtendedAttribute"/>
+    ///   cref="AttributeRecord"/> to <i>not</i> be returned even though its <see cref="AttributeRecord.IsExtendedAttribute"/>
     ///   disagrees with <see cref="AttributeDescriptor.IsExtendedAttribute"/>, since it won't match the <see
     ///   cref="TopicRepository.GetAttributes(Topic, Boolean?, Boolean?, Boolean)"/>'s <c>isExtendedAttribute</c> call.
     /// </summary>
@@ -324,7 +324,7 @@ public void GetAttributes_ExtendedAttributeMismatch_ReturnsNothing() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Retrieves a list of attributes from a topic, filtering by <c>excludeLastModified</c>. Confirms that <see
-    ///   cref="AttributeValue"/>s are not returned which start with <c>LastModified</c>.
+    ///   cref="AttributeRecord"/>s are not returned which start with <c>LastModified</c>.
     /// </summary>
     [TestMethod]
     public void GetAttributes_ExcludeLastModified_ReturnsOtherAttributes() {
@@ -345,7 +345,7 @@ public void GetAttributes_ExcludeLastModified_ReturnsOtherAttributes() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Sets an arbitrary (unmatched) attribute on a <see cref="Topic"/> with a value shorter than 255 characters, then
-    ///   ensures that it is returned as an an <i>indexed</i> <see cref="AttributeValue"/> when calling <see
+    ///   ensures that it is returned as an an <i>indexed</i> <see cref="AttributeRecord"/> when calling <see
     ///   cref="TopicRepository.GetAttributes(Topic, Boolean?, Boolean?, Boolean)"/>.
     /// </summary>
     [TestMethod]

OnTopic.Tests/TopicTest.cs

@@ -275,7 +275,7 @@ public void LastModified_UpdateValue_ReturnsExpectedValue() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Sets a base topic to a topic entity, then replaces the references with a new topic entity. Ensures that both the
-    ///   base topic as well as the underlying <see cref="AttributeValue"/> correctly reference the new value.
+    ///   base topic as well as the underlying <see cref="AttributeRecord"/> correctly reference the new value.
     /// </summary>
     [TestMethod]
     public void BaseTopic_UpdateValue_ReturnsExpectedValue() {