fix: 'no-default-props' should report only function components, closes #1131

Author: Rel1cx

packages/plugins/eslint-plugin-react-x/src/rules/no-default-props.spec.ts

@@ -14,29 +14,6 @@ ruleTester.run(RULE_NAME, rule, {
       `,
       errors: [{ messageId: "noDefaultProps" }],
     },
-    {
-      code: tsx`
-        class Input extends React.Component {
-          render() {
-            return <input />;
-          }
-        }
-        Input.defaultProps = {};
-      `,
-      errors: [{ messageId: "noDefaultProps" }],
-    },
-    {
-      code: tsx`
-        class Input extends React.Component {
-          static defaultProps = {};
-
-          render() {
-            return <input />;
-          }
-        }
-      `,
-      errors: [{ messageId: "noDefaultProps" }],
-    },
   ],
   valid: [
     ...allValid,
@@ -57,5 +34,26 @@ ruleTester.run(RULE_NAME, rule, {
         }
       }
     `,
+    {
+      code: tsx`
+        class Input extends React.Component {
+          static defaultProps = {};
+
+          render() {
+            return <input />;
+          }
+        }
+      `,
+    },
+    {
+      code: tsx`
+        class Input extends React.Component {
+          render() {
+            return <input />;
+          }
+        }
+        Input.defaultProps = {};
+      `,
+    },
   ],
 });

packages/plugins/eslint-plugin-react-x/src/rules/no-default-props.ts

@@ -51,17 +51,8 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
       const variable = VAR.findVariable(object.name, context.sourceCode.getScope(node));
       const variableNode = VAR.getVariableInitNode(variable, 0);
       if (variableNode == null) return;
-      if (!AST.isFunction(variableNode) && !ER.isClassComponent(variableNode)) return;
+      if (!AST.isFunction(variableNode)) return;
       context.report({ messageId: "noDefaultProps", node: property });
     },
-    PropertyDefinition(node) {
-      if (!ER.isClassComponent(node.parent.parent)) {
-        return;
-      }
-      if (!node.static || node.key.type !== T.Identifier || node.key.name !== "defaultProps") {
-        return;
-      }
-      context.report({ messageId: "noDefaultProps", node });
-    },
   };
 }