lint: Fix pre-commit issues

Author: mmalerba

package-lock.json

@@ -76,6 +76,8 @@
   },
   "devDependencies": {
     "@angular-devkit/build-angular": "^18.0.0",
+    "@angular-eslint/builder": "^18.0.1",
+    "@angular-eslint/eslint-plugin": "^18.0.1",
     "@angular/animations": "^18.0.0",
     "@angular/cli": "^18.0.0",
     "@angular/compiler-cli": "^18.0.0",
@@ -90,8 +92,8 @@
     "@types/semver": "^7.1.0",
     "@types/triple-beam": "^1.3.0",
     "@types/winston": "^2.4.4",
-    "@typescript-eslint/eslint-plugin": "6.13.1",
-    "@typescript-eslint/parser": "6.13.1",
+    "@typescript-eslint/eslint-plugin": "^7.11.0",
+    "@typescript-eslint/parser": "^7.11.0",
     "conventional-changelog-cli": "^1.2.0",
     "cross-spawn": "^7.0.3",
     "eslint": "^8.54.0",
@@ -118,4 +120,4 @@
     "typescript": ">=5.4 <5.5"
   },
   "typings": "index.d.ts"
-}
+}

package.json

@@ -98,7 +98,7 @@ function sliceAndSplice<T>(
 export function combineChange<T>(combined: DocumentChange<T>[], change: DocumentChange<T>): DocumentChange<T>[] {
   switch (change.type) {
     case 'added':
-      if (combined[change.newIndex] && combined[change.newIndex].doc.ref.isEqual(change.doc.ref)) {
+      if (combined[change.newIndex]?.doc.ref.isEqual(change.doc.ref)) {
         // Not sure why the duplicates are getting fired
       } else {
         return sliceAndSplice(combined, change.newIndex, 0, change);
@@ -119,7 +119,7 @@ export function combineChange<T>(combined: DocumentChange<T>[], change: Document
       }
       break;
     case 'removed':
-      if (combined[change.oldIndex] && combined[change.oldIndex].doc.ref.isEqual(change.doc.ref)) {
+      if (combined[change.oldIndex]?.doc.ref.isEqual(change.doc.ref)) {
         return sliceAndSplice(combined, change.oldIndex, 1);
       }
       break;

src/analytics/firebase.ts

@@ -17,10 +17,6 @@ import {
 } from 'rxjs';
 import { observeOn, subscribeOn, tap } from 'rxjs/operators';
 
-// eslint-disable-next-line @typescript-eslint/no-empty-function
-function noop() {
-}
-
 /**
  * Schedules tasks so that they are invoked inside the Zone that is passed in the constructor.
  */
@@ -56,7 +52,7 @@ class BlockUntilFirstOperator<T> implements Operator<T, T> {
   ) {}
 
   call(subscriber: Subscriber<T>, source: Observable<T>): TeardownLogic {
-    const taskDone = this.zone.run(() => this.pendingTasks.add());
+    const taskDone: VoidFunction = this.zone.run(() => this.pendingTasks.add());
     // maybe this is a race condition, invoke in a timeout
     // hold for 10ms while I try to figure out what is going on
     const unscheduleTask = () => setTimeout(taskDone, 10);
@@ -195,12 +191,12 @@ export const ɵzoneWrap = <T= unknown>(it: T, blockUntilFirst: boolean): T => {
       // eslint-disable-next-line @typescript-eslint/no-misused-promises
       return run(
         () =>
-          new Promise((resolve, reject) =>
+          new Promise((resolve, reject) => {
             ret.then(
               (it) => run(() => resolve(it)),
               (reason) => run(() => reject(reason))
-            )
-          )
+            );
+          })
       );
     } else if (typeof ret === "function" && taskDone) {
       // Handle unsubscribe