Make the cache service configurable and "disableable" (#647)

Author: Nyholm

src/DependencyInjection/AsyncAwsExtension.php

@@ -97,7 +97,10 @@ private function addServiceDefinition(ContainerBuilder $container, string $name,
             $httpClient = new Reference('http_client', ContainerInterface::NULL_ON_INVALID_REFERENCE);
         }
 
-        if ((null === $credentialServiceId = $config['credential_provider']) && \class_exists(SymfonyCacheProvider::class) && \interface_exists(CacheInterface::class)) {
+        // If no credential provider is specified, lets configured a credentials provider with cache.
+        $hasCacheClasses = \class_exists(SymfonyCacheProvider::class) && \interface_exists(CacheInterface::class);
+        $credentialServiceId = $config['credential_provider'];
+        if (null === $credentialServiceId && null !== $config['credential_provider_cache'] && $hasCacheClasses) {
             $credentialServiceId = 'async_aws.credential';
             if (!$container->hasDefinition($credentialServiceId)) {
                 $container->register($credentialServiceId, CredentialProvider::class)
@@ -108,14 +111,13 @@ private function addServiceDefinition(ContainerBuilder $container, string $name,
                     ->setDecoratedService($credentialServiceId)
                     ->setArguments([
                         new Reference('async_aws.credential.cache.inner'),
-                        new Reference('cache.app'),
+                        new Reference($config['credential_provider_cache']),
                     ]);
 
                 $container->register('async_aws.credential.memory', CacheProvider::class)
                     ->setDecoratedService($credentialServiceId)
                     ->setArguments([
                         new Reference('async_aws.credential.memory.inner'),
-                        new Reference('cache.app'),
                     ]);
             }
         }

src/DependencyInjection/Configuration.php

@@ -22,6 +22,7 @@ public function getConfigTreeBuilder()
             ->children()
                 ->booleanNode('register_service')->info('If set to false, no services will be created.')->defaultTrue()->end()
                 ->scalarNode('credential_provider')->info('A service name for AsyncAws\Core\Credentials\CredentialProvider.')->defaultNull()->end()
+                ->scalarNode('credential_provider_cache')->info('A service implementing Symfony\Contracts\Cache\CacheInterface to efficiently cache credentials.')->defaultValue('cache.app')->end()
                 ->scalarNode('http_client')->info('A service name for Symfony\Contracts\HttpClient\HttpClientInterface.')->end()
                 ->scalarNode('logger')->info('A service name for Psr\Log\LoggerInterface.')->end()
                 ->arrayNode('config')->info('Default config that will be merged will all services.')->normalizeKeys(false)->prototype('variable')->end()->end()

tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -26,6 +26,7 @@ public function testDefaultValues(): void
         ], [
             'register_service' => true,
             'credential_provider' => null,
+            'credential_provider_cache' => 'cache.app',
             'config' => [],
             'clients' => [],
             'secrets' => [