From beddb7addbc4cd254b00751e38ab212975b0b7c7 Mon Sep 17 00:00:00 2001
From: RogerZhang <ruojiazh@amazon.com>
Date: Mon, 30 Oct 2023 23:57:03 +0000
Subject: [PATCH] change subsequenceNumber from str to int

---
 .../utilities/data_classes/kinesis_firehose_event.py          | 2 +-
 .../utilities/parser/models/kinesis_firehose.py               | 2 +-
 tests/events/kinesisFirehoseKinesisEvent.json                 | 4 ++--
 tests/unit/parser/test_kinesis_firehose.py                    | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/aws_lambda_powertools/utilities/data_classes/kinesis_firehose_event.py b/aws_lambda_powertools/utilities/data_classes/kinesis_firehose_event.py
index dd42a09fa5e..3e5db8cb9d8 100644
--- a/aws_lambda_powertools/utilities/data_classes/kinesis_firehose_event.py
+++ b/aws_lambda_powertools/utilities/data_classes/kinesis_firehose_event.py
@@ -201,7 +201,7 @@ def sequence_number(self) -> str:
         return self._metadata["sequenceNumber"]
 
     @property
-    def subsequence_number(self) -> str:
+    def subsequence_number(self) -> int:
         """Kinesis stream sub-sequence number; present only when Kinesis Stream is source
 
         Note: this will only be present for Kinesis streams using record aggregation
diff --git a/aws_lambda_powertools/utilities/parser/models/kinesis_firehose.py b/aws_lambda_powertools/utilities/parser/models/kinesis_firehose.py
index 7edc0ba4ebf..36d1dd868fd 100644
--- a/aws_lambda_powertools/utilities/parser/models/kinesis_firehose.py
+++ b/aws_lambda_powertools/utilities/parser/models/kinesis_firehose.py
@@ -10,7 +10,7 @@ class KinesisFirehoseRecordMetadata(BaseModel):
     partitionKey: str
     approximateArrivalTimestamp: PositiveInt
     sequenceNumber: str
-    subsequenceNumber: str
+    subsequenceNumber: int
 
 
 class KinesisFirehoseRecord(BaseModel):
diff --git a/tests/events/kinesisFirehoseKinesisEvent.json b/tests/events/kinesisFirehoseKinesisEvent.json
index 5120dd57ccb..6cdd8e8a5b4 100644
--- a/tests/events/kinesisFirehoseKinesisEvent.json
+++ b/tests/events/kinesisFirehoseKinesisEvent.json
@@ -13,7 +13,7 @@
                 "partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c317a",
                 "approximateArrivalTimestamp": 1664028820148,
                 "sequenceNumber": "49546986683135544286507457936321625675700192471156785154",
-                "subsequenceNumber": ""
+                "subsequenceNumber": 0
             }
         },
         {
@@ -25,7 +25,7 @@
                 "partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c318a",
                 "approximateArrivalTimestamp": 1664028793294,
                 "sequenceNumber": "49546986683135544286507457936321625675700192471156785155",
-                "subsequenceNumber": ""
+                "subsequenceNumber": 0
             }
         }
     ]
diff --git a/tests/unit/parser/test_kinesis_firehose.py b/tests/unit/parser/test_kinesis_firehose.py
index 87eaef7ca9d..bd12d25e3d3 100644
--- a/tests/unit/parser/test_kinesis_firehose.py
+++ b/tests/unit/parser/test_kinesis_firehose.py
@@ -62,7 +62,7 @@ def test_firehose_trigger_event_kinesis_no_envelope():
 
     metadata_01: KinesisFirehoseRecordMetadata = record_01.kinesisRecordMetadata
     assert metadata_01.partitionKey == "4d1ad2b9-24f8-4b9d-a088-76e9947c317a"
-    assert metadata_01.subsequenceNumber == ""
+    assert metadata_01.subsequenceNumber == 0
     assert metadata_01.shardId == "shardId-000000000000"
     assert metadata_01.approximateArrivalTimestamp == 1664028820148
     assert metadata_01.sequenceNumber == "49546986683135544286507457936321625675700192471156785154"
@@ -74,7 +74,7 @@ def test_firehose_trigger_event_kinesis_no_envelope():
 
     metadata_02: KinesisFirehoseRecordMetadata = record_02.kinesisRecordMetadata
     assert metadata_02.partitionKey == "4d1ad2b9-24f8-4b9d-a088-76e9947c318a"
-    assert metadata_02.subsequenceNumber == ""
+    assert metadata_02.subsequenceNumber == 0
     assert metadata_02.shardId == "shardId-000000000001"
     assert metadata_02.approximateArrivalTimestamp == 1664028793294
     assert metadata_02.sequenceNumber == "49546986683135544286507457936321625675700192471156785155"