From ccad1f49d86c44528b069cf59038c27472d58d66 Mon Sep 17 00:00:00 2001 From: Stan Zubarev Date: Mon, 1 Apr 2024 18:31:12 -0400 Subject: [PATCH 1/2] Fix bug #4051 --- aws_lambda_powertools/utilities/data_classes/active_mq_event.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws_lambda_powertools/utilities/data_classes/active_mq_event.py b/aws_lambda_powertools/utilities/data_classes/active_mq_event.py index f0839a70442..ec66918e2ce 100644 --- a/aws_lambda_powertools/utilities/data_classes/active_mq_event.py +++ b/aws_lambda_powertools/utilities/data_classes/active_mq_event.py @@ -59,7 +59,7 @@ def properties(self) -> dict: @property def destination_physicalname(self) -> str: - return self["destination"]["physicalname"] + return self["destination"]["physicalName"] @property def delivery_mode(self) -> Optional[int]: From 81840f88b35e3b8fbc84f47554347a6813650f92 Mon Sep 17 00:00:00 2001 From: Leandro Damascena Date: Tue, 2 Apr 2024 08:56:32 +0100 Subject: [PATCH 2/2] Fix tests --- tests/events/activeMQEvent.json | 6 +++--- tests/unit/data_classes/test_active_mq_event.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/events/activeMQEvent.json b/tests/events/activeMQEvent.json index 57417cfd229..18ef927c4fd 100644 --- a/tests/events/activeMQEvent.json +++ b/tests/events/activeMQEvent.json @@ -9,7 +9,7 @@ "connectionId": "myJMSCoID", "redelivered": false, "destination": { - "physicalname": "testQueue" + "physicalName": "testQueue" }, "timestamp": 1598827811958, "brokerInTime": 1598827811958, @@ -25,7 +25,7 @@ "connectionId": "myJMSCoID2", "redelivered": false, "destination": { - "physicalname": "testQueue" + "physicalName": "testQueue" }, "timestamp": 1598827811958, "brokerInTime": 1598827811958, @@ -42,7 +42,7 @@ "connectionId": "myJMSCoID1", "persistent": false, "destination": { - "physicalname": "testQueue" + "physicalName": "testQueue" }, "timestamp": 1598827811958, "brokerInTime": 1598827811958, diff --git a/tests/unit/data_classes/test_active_mq_event.py b/tests/unit/data_classes/test_active_mq_event.py index 885718d50ad..f4e835edce9 100644 --- a/tests/unit/data_classes/test_active_mq_event.py +++ b/tests/unit/data_classes/test_active_mq_event.py @@ -27,7 +27,7 @@ def test_active_mq_event(): assert message.broker_in_time == raw_event["messages"][0]["brokerInTime"] assert message.broker_out_time == raw_event["messages"][0]["brokerOutTime"] assert message.properties.get("testKey") == raw_event["messages"][0]["properties"]["testKey"] - assert message.destination_physicalname == raw_event["messages"][0]["destination"]["physicalname"] + assert message.destination_physicalname == raw_event["messages"][0]["destination"]["physicalName"] assert message.delivery_mode is None assert message.correlation_id is None assert message.reply_to is None