Skip to content

Commit 352d1d4

Browse files
committed
Added new region support - AWS Seoul region
Added some preliminary contribution guidlines.
1 parent 063a11f commit 352d1d4

File tree

4 files changed

+23
-1
lines changed

4 files changed

+23
-1
lines changed

README.md

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,25 @@ getObjectRequest.SetResponseStreamFactory([](){ return Aws::New<Aws::FStream>( A
460460
auto getObjectOutcome = s3Client->GetObject(getObjectRequest);
461461
```
462462

463-
463+
###Contributing Back
464+
*Please Do!
465+
466+
#####Guidlines
467+
* Don't make changes to generated clients directly. Make your changes in the generator. Changes to Core, Scripts, and High-Level interfaces are fine directly in the code.
468+
* Do not use non-trivial statics anywhere. This will cause custom memory managers to crash in random places.
469+
* Use 4 spaces for indents and never use tabs.
470+
* No exceptions.... no exceptions. Use the Outcome pattern for returning data if you need to also return an optional error code.
471+
* Always think about platform independence. If this is impossible, put a nice abstraction on top of it and use an abstract factory.
472+
* Use RAII, Aws::New and Aws::Delete should only appear in constructors and destructors.
473+
* Be sure to follow the rule of 5.
474+
* Use the C++ 11 standard where possible.
475+
* Use UpperCamelCase for custom type names and function names. Use m_* for member variables. Don't use statics. If you must, use UpperCammelCase for static variables
476+
* Always be const correct, and be mindful of when you need to support r-values. We don't trust compilers to optimize this uniformly accross builds so please be explicit.
477+
* Namespace names should be UpperCammelCase. Never put a using namespace statement in a header file unless it is scoped by a class. It is fine to use a using namespace statement in a cpp file.
478+
* Use enum class, not enum
479+
* prefer `#pragma once for include guards.
480+
* Forward declare whenever possible.
481+
* Use nullptr instead of NULL.
464482

465483

466484

aws-cpp-sdk-core/include/aws/core/Region.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ enum class AWS_CORE_API Region
3232
AP_SOUTHEAST_1,
3333
AP_SOUTHEAST_2,
3434
AP_NORTHEAST_1,
35+
AP_NORTHEAST_2,
3536
SA_EAST_1
3637
};
3738

aws-cpp-sdk-core/source/Region.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ const char* GetRegionName(Region region)
4242
return "ap-southeast-2";
4343
case Region::AP_NORTHEAST_1:
4444
return "ap-northeast-1";
45+
case Region::AP_NORTHEAST_2:
46+
return "ap-northeast-2";
4547
case Region::SA_EAST_1:
4648
return "sa-east-1";
4749
default:

code-generation/generator/src/main/java/com/amazonaws/util/awsclientgenerator/regions/RegionEndpointMapper.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ public class RegionEndpointMapper {
3434
REGION_MAPPING_ENDPOINT_MAPPING.put("AP_SOUTHEAST_1", "ap-southeast-1.amazonaws.com");
3535
REGION_MAPPING_ENDPOINT_MAPPING.put("AP_SOUTHEAST_2", "ap-southeast-2.amazonaws.com");
3636
REGION_MAPPING_ENDPOINT_MAPPING.put("AP_NORTHEAST_1", "ap-northeast-1.amazonaws.com");
37+
REGION_MAPPING_ENDPOINT_MAPPING.put("AP_NORTHEAST_2", "ap-northeast-2.amazonaws.com");
3738
REGION_MAPPING_ENDPOINT_MAPPING.put("SA_EAST_1", "sa-east-1.amazonaws.com");
3839
}
3940

0 commit comments

Comments
 (0)