diff --git a/README.md b/README.md index c8d7ad4581b..0c3b0686b32 100644 --- a/README.md +++ b/README.md @@ -460,7 +460,25 @@ getObjectRequest.SetResponseStreamFactory([](){ return Aws::New( A auto getObjectOutcome = s3Client->GetObject(getObjectRequest); ``` - +###Contributing Back +*Please Do! + +#####Guidlines +* Don't make changes to generated clients directly. Make your changes in the generator. Changes to Core, Scripts, and High-Level interfaces are fine directly in the code. +* Do not use non-trivial statics anywhere. This will cause custom memory managers to crash in random places. +* Use 4 spaces for indents and never use tabs. +* No exceptions.... no exceptions. Use the Outcome pattern for returning data if you need to also return an optional error code. +* Always think about platform independence. If this is impossible, put a nice abstraction on top of it and use an abstract factory. +* Use RAII, Aws::New and Aws::Delete should only appear in constructors and destructors. +* Be sure to follow the rule of 5. +* Use the C++ 11 standard where possible. +* Use UpperCamelCase for custom type names and function names. Use m_* for member variables. Don't use statics. If you must, use UpperCammelCase for static variables +* Always be const correct, and be mindful of when you need to support r-values. We don't trust compilers to optimize this uniformly accross builds so please be explicit. +* Namespace names should be UpperCammelCase. Never put a using namespace statement in a header file unless it is scoped by a class. It is fine to use a using namespace statement in a cpp file. +* Use enum class, not enum +* prefer `#pragma once for include guards. +* Forward declare whenever possible. +* Use nullptr instead of NULL. diff --git a/aws-cpp-sdk-core/include/aws/core/Region.h b/aws-cpp-sdk-core/include/aws/core/Region.h index 957a3ed4ac0..9e1871d02f8 100644 --- a/aws-cpp-sdk-core/include/aws/core/Region.h +++ b/aws-cpp-sdk-core/include/aws/core/Region.h @@ -32,6 +32,7 @@ enum class AWS_CORE_API Region AP_SOUTHEAST_1, AP_SOUTHEAST_2, AP_NORTHEAST_1, + AP_NORTHEAST_2, SA_EAST_1 }; diff --git a/aws-cpp-sdk-core/source/Region.cpp b/aws-cpp-sdk-core/source/Region.cpp index 4ff4e516735..53f4f8ca441 100644 --- a/aws-cpp-sdk-core/source/Region.cpp +++ b/aws-cpp-sdk-core/source/Region.cpp @@ -42,6 +42,8 @@ const char* GetRegionName(Region region) return "ap-southeast-2"; case Region::AP_NORTHEAST_1: return "ap-northeast-1"; + case Region::AP_NORTHEAST_2: + return "ap-northeast-2"; case Region::SA_EAST_1: return "sa-east-1"; default: diff --git a/code-generation/generator/src/main/java/com/amazonaws/util/awsclientgenerator/regions/RegionEndpointMapper.java b/code-generation/generator/src/main/java/com/amazonaws/util/awsclientgenerator/regions/RegionEndpointMapper.java index 743b34e7bbc..8b74001c4ed 100644 --- a/code-generation/generator/src/main/java/com/amazonaws/util/awsclientgenerator/regions/RegionEndpointMapper.java +++ b/code-generation/generator/src/main/java/com/amazonaws/util/awsclientgenerator/regions/RegionEndpointMapper.java @@ -34,6 +34,7 @@ public class RegionEndpointMapper { REGION_MAPPING_ENDPOINT_MAPPING.put("AP_SOUTHEAST_1", "ap-southeast-1.amazonaws.com"); REGION_MAPPING_ENDPOINT_MAPPING.put("AP_SOUTHEAST_2", "ap-southeast-2.amazonaws.com"); REGION_MAPPING_ENDPOINT_MAPPING.put("AP_NORTHEAST_1", "ap-northeast-1.amazonaws.com"); + REGION_MAPPING_ENDPOINT_MAPPING.put("AP_NORTHEAST_2", "ap-northeast-2.amazonaws.com"); REGION_MAPPING_ENDPOINT_MAPPING.put("SA_EAST_1", "sa-east-1.amazonaws.com"); }