Merge #12: Code cleanup

0b5f3c7 Implement Eq if all fields implement Eq (Gabriel Comte)
7c27d6b Remove to_string() because type implements Display (Gabriel Comte)

Pull request description:

  Implement Clippy warnings

Top commit has no ACKs.

Tree-SHA512: 9992864ba90d8cc24694d397cf8f2f32a53f3a1429ac161a989f76179e2dc19bea7a7f12efd06dd73dda53c083753f647cf4247ebdad6c472fb6c5b5888a7476

Author: vladimirfomene

src/api.rs

@@ -7,13 +7,13 @@ use bitcoin::{BlockHash, OutPoint, Script, Transaction, TxIn, TxOut, Txid, Witne
 
 use serde::Deserialize;
 
-#[derive(Deserialize, Clone, Debug, PartialEq)]
+#[derive(Deserialize, Clone, Debug, PartialEq, Eq)]
 pub struct PrevOut {
     pub value: u64,
     pub scriptpubkey: Script,
 }
 
-#[derive(Deserialize, Clone, Debug, PartialEq)]
+#[derive(Deserialize, Clone, Debug, PartialEq, Eq)]
 pub struct Vin {
     pub txid: Txid,
     pub vout: u32,
@@ -26,28 +26,28 @@ pub struct Vin {
     pub is_coinbase: bool,
 }
 
-#[derive(Deserialize, Clone, Debug, PartialEq)]
+#[derive(Deserialize, Clone, Debug, PartialEq, Eq)]
 pub struct Vout {
     pub value: u64,
     pub scriptpubkey: Script,
 }
 
-#[derive(Deserialize, Clone, Debug, PartialEq)]
+#[derive(Deserialize, Clone, Debug, PartialEq, Eq)]
 pub struct TxStatus {
     pub confirmed: bool,
     pub block_height: Option<u32>,
     pub block_hash: Option<BlockHash>,
     pub block_time: Option<u64>,
 }
 
-#[derive(Deserialize, Clone, Debug, PartialEq)]
+#[derive(Deserialize, Clone, Debug, PartialEq, Eq)]
 pub struct MerkleProof {
     pub block_height: u32,
     pub merkle: Vec<Txid>,
     pub pos: usize,
 }
 
-#[derive(Deserialize, Clone, Debug, PartialEq)]
+#[derive(Deserialize, Clone, Debug, PartialEq, Eq)]
 pub struct OutputStatus {
     pub spent: bool,
     pub txid: Option<Txid>,

src/async.rs

@@ -87,12 +87,7 @@ impl AsyncClient {
     ) -> Result<Option<Txid>, Error> {
         let resp = self
             .client
-            .get(&format!(
-                "{}/block/{}/txid/{}",
-                self.url,
-                block_hash.to_string(),
-                index
-            ))
+            .get(&format!("{}/block/{}/txid/{}", self.url, block_hash, index))
             .send()
             .await?;
 

src/blocking.rs

@@ -92,12 +92,7 @@ impl BlockingClient {
     ) -> Result<Option<Txid>, Error> {
         let resp = self
             .agent
-            .get(&format!(
-                "{}/block/{}/txid/{}",
-                self.url,
-                block_hash.to_string(),
-                index
-            ))
+            .get(&format!("{}/block/{}/txid/{}", self.url, block_hash, index))
             .call();
 
         match resp {