fix(tests): WriterTestSuite.handleNulls should not overwrite columns (#1920)

disq · web-flow · commit 08e18e265dfb · 2024-10-04T09:48:52.000Z
diff --git a/plugin/nulls.go b/plugin/nulls.go
@@ -93,10 +93,11 @@ func (s *WriterTestSuite) replaceNullsByEmptyNestedArray(arr arrow.Array) arrow.
 
 func (s *WriterTestSuite) handleNulls(record arrow.Record) arrow.Record {
 	cols := record.Columns()
+	newCols := make([]arrow.Array, len(cols))
 	for c, col := range cols {
-		cols[c] = s.handleNullsArray(col)
+		newCols[c] = s.handleNullsArray(col)
 	}
-	return array.NewRecord(record.Schema(), cols, record.NumRows())
+	return array.NewRecord(record.Schema(), newCols, record.NumRows())
 }
 
 func (s *WriterTestSuite) handleNullsArray(arr arrow.Array) arrow.Array {

Original file line number	Diff line number	Diff line change
`@@ -93,10 +93,11 @@ func (s *WriterTestSuite) replaceNullsByEmptyNestedArray(arr arrow.Array) arrow.`
`93`	`93`
`94`	`94`	`func (s *WriterTestSuite) handleNulls(record arrow.Record) arrow.Record {`
`95`	`95`	`cols := record.Columns()`
	`96`	`+ newCols := make([]arrow.Array, len(cols))`
`96`	`97`	`for c, col := range cols {`
`97`		`- cols[c] = s.handleNullsArray(col)`
	`98`	`+ newCols[c] = s.handleNullsArray(col)`
`98`	`99`	`}`
`99`		`- return array.NewRecord(record.Schema(), cols, record.NumRows())`
	`100`	`+ return array.NewRecord(record.Schema(), newCols, record.NumRows())`
`100`	`101`	`}`
`101`	`102`
`102`	`103`	`func (s *WriterTestSuite) handleNullsArray(arr arrow.Array) arrow.Array {`