Deprecate constructor with unused parameters

Author: gnodet

src/main/java/org/codehaus/plexus/components/io/attributes/FileAttributes.java

@@ -67,10 +67,20 @@ public class FileAttributes
 
     private final FileTime lastModifiedTime;
 
+    /**
+     * @deprecated use {@link #FileAttributes(File)} and remove the unused userCache and groupCache parameters
+     */
+    @Deprecated
     public FileAttributes( @Nonnull File file, @Nonnull Map<Integer, String> userCache,
                            @Nonnull Map<Integer, String> groupCache )
         throws IOException
     {
+        this( file );
+    }
+
+    public FileAttributes( @Nonnull File file )
+            throws IOException
+    {
 
         Path path = file.toPath();
         Set<String> views = path.getFileSystem().supportedFileAttributeViews();
@@ -130,7 +140,7 @@ public FileAttributes( @Nullable Integer userId, String userName, @Nullable Inte
     PlexusIoResourceAttributes uncached( @Nonnull File file )
         throws IOException
     {
-        return new FileAttributes( file, new HashMap<Integer, String>(), new HashMap<Integer, String>() );
+        return new FileAttributes( file );
     }
 
     @Nullable

src/main/java/org/codehaus/plexus/components/io/attributes/PlexusIoResourceAttributeUtils.java

@@ -22,7 +22,6 @@
 import java.io.File;
 import java.io.IOException;
 import java.util.Collections;
-import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
@@ -160,7 +159,6 @@ public static boolean isOctalModeEnabled( int mode, int targetMode )
         return ( mode & targetMode ) != 0;
     }
 
-    @SuppressWarnings( { "UnusedDeclaration" } )
     public static PlexusIoResourceAttributes getFileAttributes( File file )
         throws IOException
     {
@@ -186,8 +184,6 @@ Map<String, PlexusIoResourceAttributes> getFileAttributesByPath( @Nonnull File d
                                                                      boolean recursive )
         throws IOException
     {
-        Map<Integer, String> userCache = new HashMap<>();
-        Map<Integer, String> groupCache = new HashMap<>();
         final List<String> fileAndDirectoryNames;
         if ( recursive && dir.isDirectory() )
         {
@@ -202,8 +198,7 @@ Map<String, PlexusIoResourceAttributes> getFileAttributesByPath( @Nonnull File d
 
         for ( String fileAndDirectoryName : fileAndDirectoryNames )
         {
-            attributesByPath.put( fileAndDirectoryName,
-                                  new FileAttributes( new File( fileAndDirectoryName ), userCache, groupCache ) );
+            attributesByPath.put( fileAndDirectoryName, new FileAttributes( new File( fileAndDirectoryName ) ) );
         }
         return attributesByPath;
     }

src/main/java/org/codehaus/plexus/components/io/resources/PlexusIoFileResourceCollection.java

@@ -152,14 +152,12 @@ private void addResources( List<PlexusIoResource> result, String[] resources )
     {
 
         final File dir = getBaseDir();
-        final HashMap<Integer, String> cache1 = new HashMap<>();
-        final HashMap<Integer, String> cache2 = new HashMap<>();
         for ( String name : resources )
         {
             String sourceDir = name.replace( '\\', '/' );
             File f = new File( dir, sourceDir );
 
-            FileAttributes fattrs = new FileAttributes( f, cache1, cache2 );
+            FileAttributes fattrs = new FileAttributes( f );
             PlexusIoResourceAttributes attrs = mergeAttributes( fattrs, fattrs.isDirectory() );
 
             String remappedName = getName( name );

src/test/java/org/codehaus/plexus/components/io/attributes/AttributeUtilsTest.java

@@ -54,14 +54,12 @@ public void testChmodBackAndForth()
             return;
         final File bxx = File.createTempFile( "bxx", "ff" );
         AttributeUtils.chmod( bxx, 0422 );
-        PlexusIoResourceAttributes firstAttrs =
-            new FileAttributes( bxx, new HashMap<Integer, String>(), new HashMap<Integer, String>() );
+        PlexusIoResourceAttributes firstAttrs = new FileAttributes( bxx );
         assertTrue( firstAttrs.isOwnerReadable() );
         assertFalse( firstAttrs.isOwnerWritable() );
         assertFalse( firstAttrs.isOwnerExecutable() );
         AttributeUtils.chmod( bxx, 0777 );
-        PlexusIoResourceAttributes secondAttrs =
-            new FileAttributes( bxx, new HashMap<Integer, String>(), new HashMap<Integer, String>() );
+        PlexusIoResourceAttributes secondAttrs = new FileAttributes( bxx );
         assertTrue( secondAttrs.isOwnerReadable() );
         assertTrue( secondAttrs.isOwnerWritable() );
         assertTrue( secondAttrs.isOwnerExecutable() );

src/test/java/org/codehaus/plexus/components/io/attributes/FileAttributesTest.java

@@ -39,10 +39,8 @@ public void testGetPosixFileAttributes()
         }
 
         File file = new File( "." );
-        Map<Integer, String> userCache = new HashMap<>();
-        Map<Integer, String> groupCache = new HashMap<>();
 
-        PlexusIoResourceAttributes fa = new FileAttributes( file, userCache, groupCache );
+        PlexusIoResourceAttributes fa = new FileAttributes( file );
         assertNotNull( fa );
     }