Fix maintainer feedback: always return strings from readInt64/unpackUInt64

- Changed readInt64() to always return string instead of string|int
- Changed unpackUInt64() to always return string instead of string|int
- Changed readUInt64() return type to string for consistency
- Applied code style fixes with composer cs:fix
- Fixes failing tests: testShouldReadInt64 and testShouldPack64bit

Addresses maintainer feedback from PR krowinski#116 regarding MySQL 8.4.0 compatibility.

Author: cyppe

src/MySQLReplication/BinLog/BinLogSocketConnect.php

@@ -195,11 +195,11 @@ private function getBinlogStream(): void
 
         if ($this->config->heartbeatPeriod > 0.00) {
             // master_heartbeat_period is in nanoseconds
-			if(version_compare($this->repository->getVersion(),"8.4.0")>=0){
-				$this->executeSQL('SET @source_heartbeat_period = ' . $this->config->heartbeatPeriod * 1000000000);
-			}else{
-				$this->executeSQL('SET @master_heartbeat_period = ' . $this->config->heartbeatPeriod * 1000000000);
-			}
+            if (version_compare($this->repository->getVersion(), '8.4.0') >= 0) {
+                $this->executeSQL('SET @source_heartbeat_period = ' . $this->config->heartbeatPeriod * 1000000000);
+            } else {
+                $this->executeSQL('SET @master_heartbeat_period = ' . $this->config->heartbeatPeriod * 1000000000);
+            }
 
             $this->logger->debug('Heartbeat period set to ' . $this->config->heartbeatPeriod . ' seconds');
         }

src/MySQLReplication/BinaryDataReader/BinaryDataReader.php

@@ -114,21 +114,16 @@ public function readUInt24(): int
         return $data[1] + ($data[2] << 8) + ($data[3] << 16);
     }
 
-    public function readUInt64(): string|int
+    public function readUInt64(): string
     {
         return $this->unpackUInt64($this->read(self::UNSIGNED_INT64_LENGTH));
     }
 
-    public function unpackUInt64(string $binary): string|int
+    public function unpackUInt64(string $binary): string
     {
         $data = self::unpack('V*', $binary);
 
-        $num = bcadd((string)$data[1], bcmul((string)$data[2], bcpow('2', '32')));
-		if($num>PHP_INT_MAX || $num<PHP_INT_MIN){
-			return $num;
-		}else{
-			return intval($num);
-		}
+        return bcadd((string)$data[1], bcmul((string)$data[2], bcpow('2', '32')));
     }
 
     public function readInt24(): int
@@ -143,16 +138,11 @@ public function readInt24(): int
         return $res;
     }
 
-    public function readInt64(): string|int
+    public function readInt64(): string
     {
         $data = self::unpack('V*', $this->read(self::UNSIGNED_INT64_LENGTH));
 
-        $num = bcadd((string)$data[1], (string)($data[2] << 32));
-		if($num>PHP_INT_MAX || $num<PHP_INT_MIN){
-			return $num;
-		}else{
-			return intval($num);
-		}
+        return bcadd((string)$data[1], (string)($data[2] << 32));
     }
 
     public function readLengthString(int $size): string

src/MySQLReplication/Config/Config.php

@@ -106,7 +106,7 @@ public function validate(): void
     public function checkDataBasesOnly(string $database): bool
     {
         return ($this->databasesOnly !== [] && !in_array($database, $this->databasesOnly, true))
-            || ($this->databasesRegex !== []  && !self::matchNames($database, $this->databasesRegex));
+            || ($this->databasesRegex !== [] && !self::matchNames($database, $this->databasesRegex));
     }
 
 
@@ -116,17 +116,6 @@ public function checkTablesOnly(string $table): bool
             || ($this->tablesRegex !== [] && !self::matchNames($table, $this->tablesRegex));
     }
 
-    private static function matchNames(string $name, array $patterns): bool
-    {
-        foreach ($patterns as $pattern) {
-            if (preg_match($pattern, $name)) {
-                return true;
-            }
-        }
-
-        return false;
-    }
-
     public function checkEvent(int $type): bool
     {
         if ($this->eventsOnly !== [] && !in_array($type, $this->eventsOnly, true)) {
@@ -144,4 +133,15 @@ public function jsonSerialize(): array
     {
         return get_class_vars(self::class);
     }
+
+    private static function matchNames(string $name, array $patterns): bool
+    {
+        foreach ($patterns as $pattern) {
+            if (preg_match($pattern, $name)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }

src/MySQLReplication/Repository/MySQLRepository.php

@@ -60,7 +60,7 @@ public function getVersion(): string
         $res = $this->getConnection()
             ->fetchAssociative('SHOW VARIABLES LIKE "version"');
 
-        return $res['Value']??"";
+        return $res['Value'] ?? '';
     }
 
     public function getMasterStatus(): MasterStatusDTO

tests/Unit/Repository/MySQLRepositoryTest.php

@@ -70,14 +70,14 @@ public function testShouldIsCheckSum(): void
 
     public function testShouldGetVersion(): void
     {
-	$expected = [
-	    'Value' => 'version',
-	];
+        $expected = [
+            'Value' => 'version',
+        ];
 
-	$this->connection->method('fetchAssociative')
-		  ->willReturn($expected);
+        $this->connection->method('fetchAssociative')
+              ->willReturn($expected);
 
-	self::assertEquals('version', $this->mySQLRepositoryTest->getVersion());
+        self::assertEquals('version', $this->mySQLRepositoryTest->getVersion());
     }
 
     public function testShouldGetMasterStatus(): void