Merged PR 9189: Modify WebSockets ValueTaskSource

Create the GCHandle per operation and Free it when resetting the ValueTaskSource for re-use.

Author: BrennanConroy

src/Servers/IIS/IIS/src/Core/IO/WebSocketsAsyncIOEngine.Read.cs

@@ -25,19 +25,19 @@ internal class WebSocketReadOperation : AsyncIOOperation
             };
 
             private readonly WebSocketsAsyncIOEngine _engine;
-            private readonly GCHandle _thisHandle;
+            private GCHandle _thisHandle;
             private MemoryHandle _inputHandle;
             private IntPtr _requestHandler;
             private Memory<byte> _memory;
 
             public WebSocketReadOperation(WebSocketsAsyncIOEngine engine)
             {
                 _engine = engine;
-                _thisHandle = GCHandle.Alloc(this);
             }
 
             protected override unsafe bool InvokeOperation(out int hr, out int bytes)
             {
+                _thisHandle = GCHandle.Alloc(this);
                 _inputHandle = _memory.Pin();
 
                 hr = NativeMethods.HttpWebsocketsReadBytes(
@@ -67,6 +67,8 @@ protected override void ResetOperation()
             {
                 base.ResetOperation();
 
+                _thisHandle.Free();
+
                 _memory = default;
                 _inputHandle.Dispose();
                 _inputHandle = default;

src/Servers/IIS/IIS/src/Core/IO/WebSocketsAsyncIOEngine.Write.cs

@@ -25,23 +25,25 @@ internal sealed class WebSocketWriteOperation : AsyncWriteOperationBase
             };
 
             private readonly WebSocketsAsyncIOEngine _engine;
-            private readonly GCHandle _thisHandle;
+            private GCHandle _thisHandle;
 
             public WebSocketWriteOperation(WebSocketsAsyncIOEngine engine)
             {
                 _engine = engine;
-                _thisHandle = GCHandle.Alloc(this);
             }
 
             protected override unsafe int WriteChunks(IntPtr requestHandler, int chunkCount, HttpApiTypes.HTTP_DATA_CHUNK* dataChunks, out bool completionExpected)
             {
+                _thisHandle = GCHandle.Alloc(this);
                 return NativeMethods.HttpWebsocketsWriteBytes(requestHandler, dataChunks, chunkCount, WriteCallback, (IntPtr)_thisHandle, out completionExpected);
             }
 
             protected override void ResetOperation()
             {
                 base.ResetOperation();
 
+                _thisHandle.Free();
+
                 _engine.ReturnOperation(this);
             }
         }

src/Servers/IIS/IIS/src/Core/IO/WebSocketsAsyncIOEngine.cs

@@ -39,7 +39,7 @@ public ValueTask<int> ReadAsync(Memory<byte> memory)
                 var read = GetReadOperation();
                 read.Initialize(_handler, memory);
                 read.Invoke();
-                return new ValueTask<int>(read, 0);   
+                return new ValueTask<int>(read, 0);
             }
         }