Skip to content

[main] Update dependencies from dotnet/arcade #10291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 28, 2025
Merged

[main] Update dependencies from dotnet/arcade #10291

merged 12 commits into from
Jan 28, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 16, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 840bf684-917a-4879-f62c-08d8e93a0c51
  • Build: 20250127.3
  • Date Produced: January 27, 2025 7:00:05 PM UTC
  • Commit: 79e2c58673f7995efcac816a0a41f108de386ca8
  • Branch: refs/heads/main
  • Updates to .NET SDKs:
    • Updates sdk.version to 10.0.100-alpha.1.25077.2
    • Updates tools.dotnet to 10.0.100-alpha.1.25077.2
Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
402725e 
…115.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25065.4
@dotnet-maestro dotnet-maestro bot requested review from a team as code owners January 16, 2025 05:01
dotnet-policy-service[bot]
dotnet-policy-service bot previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 16, 2025
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
8386d99 
…116.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25066.1
@harshit7962
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

siagupta0202 and others added 3 commits January 18, 2025 10:20
@siagupta0202
Adding compiler warning suppression for CS0414 to fix build failure
f858cfd
@siagupta0202
Removing extra line
6dd836c
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
87942c9 
…117.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25067.3
@siagupta0202
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@harshit7962
Copy link
Member

@mmitche the test failing here is tyring to create XamlAccessLevel instance using obj.AccessLevel = XamlAccessLevel.AssemblyAccessTo(typeof(int).Assembly). This leads to System.PlatformNotSupportedException : System.Windows.Extensions types are not supported on this platform.

This is similar to the issue here. Is there a mismatch in dependencies similar to this one?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
362e3fe 
…120.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25070.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
1c2ae8a 
…121.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25071.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
f72fd2e 
…122.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25072.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
6feffff 
…123.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25073.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
0e3f59c 
…124.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25074.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
0d93f46 
…126.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25076.1
@harshit7962
Copy link
Member

harshit7962 commented Jan 27, 2025 •
edited
Loading

@ericstj, @ViktorHofer can we get some help on the test failure here? Had a chat with Matt and it was suggested that it could be due to runtime.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 27, 2025 •
edited
Loading

This one is very interesting. First of all, the error is correct. Those types should only be instantiated on Windows platforms. Looking at your CI legs, you only build and run on Windows though.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 27, 2025 •
edited
Loading

This is unrelated to any runtime change. My guess is that is related to a recent deps.json change in SDK. Need to build locally.

The runtime specific file gets correctly copied to the output directory:

Copying file from "D:\a_work\1\s.packages\system.windows.extensions\10.0.0-alpha.1.25072.13\runtimes\win\lib\net10.0\System.Windows.Extensions.dll" to "D:\a_work\1\s\artifacts\bin\System.Xaml.Tests\x86\Debug\net10.0\runtimes\win\lib\net10.0\System.Windows.Extensions.dll".

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 27, 2025 •
edited
Loading

Yes this is due to dotnet/sdk#45259 (cc @Forgind @dsplaisted)

Runtime specific assets get excluded from the deps.json file and hence the host loads the runtime agnostic asset instead.

image

This got reverted in 9.0.2xx but I still see the code path in main. We must get this reverted before we branch of for P1 today in SDK.

@ViktorHofer ViktorHofer mentioned this pull request Jan 27, 2025
Merged
@dsplaisted
Copy link
Member

The revert was backported in dotnet/sdk#46324.

@dsplaisted
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dsplaisted
Copy link
Member

Oops, I thought this PR was for the SDK repo and so the backport would have unblocked this PR. Looks like we're waiting for the updated SDK version to flow into Arcade and then the Arcade version in this PR to be updated to unblock.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
69b1edf 
…127.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.Helix.Sdk
 From Version 10.0.0-beta.25061.1 -> To Version 10.0.0-beta.25077.3
@himgoyalmicro himgoyalmicro merged commit b91c5d1 into main Jan 28, 2025
9 checks passed
@himgoyalmicro himgoyalmicro deleted the darc-main-6e56b768-6d74-4a4f-bcdc-0b9a940c0211 branch January 28, 2025 05:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@himgoyalmicro himgoyalmicro himgoyalmicro approved these changes

@dotnet-policy-service dotnet-policy-service[bot] dotnet-policy-service[bot] left review comments

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@Kuldeep-MS Kuldeep-MS Awaiting requested review from Kuldeep-MS

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshit7962 @siagupta0202 @ViktorHofer @dsplaisted @himgoyalmicro