Skip to content

Commit 323f90e

Browse files
author
Dana Powers
committed
Fixup client_async tests for connect_blocking
1 parent feea0df commit 323f90e

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

test/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ def _set_conn_state(state):
128128
return state
129129
conn._set_conn_state = _set_conn_state
130130
conn.connect.side_effect = lambda: conn.state
131+
conn.connect_blocking.return_value = True
131132
conn.connecting = lambda: conn.state in (ConnectionStates.CONNECTING,
132133
ConnectionStates.HANDSHAKE)
133134
conn.connected = lambda: conn.state is ConnectionStates.CONNECTED

test/test_client_async.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,21 +55,22 @@ def test_bootstrap_success(conn):
5555
kwargs.pop('state_change_callback')
5656
kwargs.pop('node_id')
5757
assert kwargs == cli.config
58-
conn.connect.assert_called_with()
58+
conn.connect_blocking.assert_called_with()
5959
conn.send.assert_called_once_with(MetadataRequest[0]([]))
6060
assert cli._bootstrap_fails == 0
6161
assert cli.cluster.brokers() == set([BrokerMetadata(0, 'foo', 12, None),
6262
BrokerMetadata(1, 'bar', 34, None)])
6363

64+
6465
def test_bootstrap_failure(conn):
65-
conn.state = ConnectionStates.DISCONNECTED
66+
conn.connect_blocking.return_value = False
6667
cli = KafkaClient(api_version=(0, 9))
6768
args, kwargs = conn.call_args
6869
assert args == ('localhost', 9092, socket.AF_UNSPEC)
6970
kwargs.pop('state_change_callback')
7071
kwargs.pop('node_id')
7172
assert kwargs == cli.config
72-
conn.connect.assert_called_with()
73+
conn.connect_blocking.assert_called_with()
7374
conn.close.assert_called_with()
7475
assert cli._bootstrap_fails == 1
7576
assert cli.cluster.brokers() == set()

0 commit comments

Comments
 (0)