Skip to content

Commit 745dbf1

Browse files
committed
Remove support for api versions as strings from KafkaAdmin
This is a new class, so let's not support the old version strings and saddle ourselves with tech debt right from the get-go.
1 parent 698b5ce commit 745dbf1

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

kafka/admin/kafka.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -181,16 +181,6 @@ def __init__(self, **configs):
181181
self.config = copy.copy(self.DEFAULT_CONFIG)
182182
self.config.update(configs)
183183

184-
# api_version was previously a str. accept old format for now
185-
if isinstance(self.config['api_version'], str):
186-
deprecated = self.config['api_version']
187-
if deprecated == 'auto':
188-
self.config['api_version'] = None
189-
else:
190-
self.config['api_version'] = tuple(map(int, deprecated.split('.')))
191-
log.warning('use api_version=%s [tuple] -- "%s" as str is deprecated',
192-
str(self.config['api_version']), deprecated)
193-
194184
# Configure metrics
195185
metrics_tags = {'client-id': self.config['client_id']}
196186
metric_config = MetricConfig(samples=self.config['metrics_num_samples'],

0 commit comments

Comments
 (0)