Skip to content

Commit 7d2ecfa

Browse files
committed
3+ kafka-topics.sh uses --bootstrap-server not --zookeeper
1 parent f703068 commit 7d2ecfa

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

test/fixtures.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -620,15 +620,18 @@ def _create_topic_via_cli(self, topic_name, num_partitions, replication_factor):
620620
raise RuntimeError("Failed to create topic %s" % (topic_name,))
621621

622622
def get_topic_names(self):
623-
args = self.run_script('kafka-topics.sh',
624-
'--zookeeper', '%s:%s/%s' % (self.zookeeper.host,
625-
self.zookeeper.port,
626-
self.zk_chroot),
627-
'--list'
628-
)
623+
args = ['--list']
624+
if env_kafka_version() < (3, 0, 0):
625+
args.append('--zookeeper')
626+
args.append('%s:%s/%s' % (self.zookeeper.host, self.zookeeper.port, self.zk_chroot))
627+
else:
628+
args.append('--bootstrap-server')
629+
args.append('%s:%s' % (self.host, self.port))
630+
631+
cmd = self.run_script('kafka-topics.sh', *args)
629632
env = self.kafka_run_class_env()
630633
env.pop('KAFKA_LOG4J_OPTS')
631-
proc = subprocess.Popen(args, env=env, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
634+
proc = subprocess.Popen(cmd, env=env, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
632635
stdout, stderr = proc.communicate()
633636
if proc.returncode != 0:
634637
self.out("Failed to list topics!")

0 commit comments

Comments
 (0)