Skip to content

Commit 2bac663

Browse files
committed
chore: stop periodic task earlier during the shutdown process
Fixes #4151 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
1 parent e7b49fa commit 2bac663

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/server/engine_shard.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -403,11 +403,10 @@ void EngineShard::Shutdown() {
403403
queue2_.Shutdown();
404404
DCHECK(!fiber_heartbeat_periodic_.IsJoinable());
405405
DCHECK(!fiber_shard_handler_periodic_.IsJoinable());
406-
407-
ProactorBase::me()->RemoveOnIdleTask(defrag_task_);
408406
}
409407

410408
void EngineShard::StopPeriodicFiber() {
409+
ProactorBase::me()->RemoveOnIdleTask(defrag_task_);
411410
fiber_heartbeat_periodic_done_.Notify();
412411
if (fiber_heartbeat_periodic_.IsJoinable()) {
413412
fiber_heartbeat_periodic_.Join();

0 commit comments

Comments
 (0)