Skip to content

Commit 002fc2d

Browse files
committed
Align OutputConfigurationQuery/Configuration for sourceTypeId
In the OutputConfigurationQuery the configuration source type id was called typeId and it creates a Configuration object where the same field is called sourceTypeId for the same field. When serializing the Configuration in the derived DataProviderDescriptor over TSP the field is called sourceTypeId and this is not consistent. The returned Configuration should have the exact field names that are used when creating the data provider and the respective configuration. The Configuration is already API while OutputConfigurationQuery is not, and it's better to change the name there. Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
1 parent 598a749 commit 002fc2d

File tree

1 file changed

+4
-4
lines changed
  • tsp-typescript-client/src/models/query

1 file changed

+4
-4
lines changed

tsp-typescript-client/src/models/query/query.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,17 @@ export class OutputConfigurationQuery extends ConfigurationQuery {
4949
* The configuration source type ID
5050
*/
5151
// @ts-expect-error TS doesn't like unused private fields.
52-
private typeId: string;
52+
private sourceTypeId: string;
5353

5454
/**
5555
* Constructor
5656
* @param name Name of the configuration
5757
* @param description Optional description of the configuraiton
58-
* @param typeId The ID of the configuration source type
58+
* @param sourceTypeId The ID of the configuration source type
5959
* @param parameters Object used to send parameters to the server
6060
*/
61-
constructor(name: string, description: string | undefined, typeId: string, parameters: Object) {
61+
constructor(name: string, description: string | undefined, sourceTypeId: string, parameters: Object) {
6262
super(name, description, parameters);
63-
this.typeId = typeId;
63+
this.sourceTypeId = sourceTypeId;
6464
}
6565
}

0 commit comments

Comments
 (0)