Skip to content

Commit d646072

Browse files
[lerna] upgrade to recent version
During the "yarn upgrade" that came along the lerna upgrade, it was found that the "tslint" dependencies were no longer valid (deprecated, old). Manually running tslint from the master branch revealed that the repo's code has not been following the configured rules, probably for a long time (>100 violations). In consequence, I think the best approach at this time is to remove tslint's dependencies and configs. We can consider adding ESLint to the repo, separately, if desired. Fixes #84 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
1 parent d8f8dcc commit d646072

File tree

9 files changed

+3031
-3736
lines changed

9 files changed

+3031
-3736
lines changed

lerna.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
2-
"lerna": "4.0.0",
2+
"lerna": "7.3.0",
33
"version": "0.3.0",
4-
"useWorkspaces": true,
54
"npmClient": "yarn",
65
"command": {
76
"run": {

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@
2121
"src"
2222
],
2323
"devDependencies": {
24-
"lerna": "4.0.0",
25-
"typescript": "latest"
24+
"lerna": "^7.0.0",
25+
"typescript": "^5.2.2"
2626
},
2727
"dependencies": {
2828
"node-fetch": "^2.5.0"
2929
},
3030
"workspaces": [
3131
"tsp-typescript-client"
32-
],
32+
],
3333
"scripts": {
3434
"prepare": "yarn build",
3535
"build": "lerna run build",

tslint.json

Lines changed: 0 additions & 86 deletions
This file was deleted.

tsp-typescript-client/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@
1515
"@types/node": "^11.13.8",
1616
"@types/node-fetch": "^2.3.3",
1717
"jest": "^27.1.0",
18-
"tslint": "^5.16.0",
19-
"tslint-language-service": "^0.9.9",
20-
"typescript": "latest"
18+
"typescript": "^5.2.2"
2119
},
2220
"dependencies": {
2321
"json-bigint": "sidorares/json-bigint#2c0a5f896d7888e68e5f4ae3c7ea5cd42fd54473",

tsp-typescript-client/src/protocol/rest-client.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// tslint:disable: no-unused-expression
2-
31
import { URLSearchParams } from 'url';
42
import { RestClient } from './rest-client';
53

tsp-typescript-client/src/protocol/serialization.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,6 @@ export function record<T>(normalizer: Normalizer<T>): Normalizer<Record<string,
193193
* Throw if `input` is not a `number`.
194194
*/
195195
export const assertNumber: Normalizer<number> =
196-
// tslint:disable-next-line: no-shadowed-variable
197196
function assertNumber(input: unknown): number {
198197
if (typeof input !== 'number') {
199198
throw new TypeError(`"${input}" is not a number!`);
@@ -205,4 +204,3 @@ export const toBigInt: Normalizer<bigint> =
205204
function toBigInt(value: number | bigint): bigint {
206205
return BigInt(value);
207206
};
208-

tsp-typescript-client/src/protocol/tsp-client.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// tslint:disable: no-unused-expression
2-
31
import { Headers } from 'node-fetch';
42
import { Query } from '../models/query/query';
53
import { HttpRequest, HttpResponse, RestClient } from './rest-client';
@@ -335,8 +333,8 @@ describe('HttpTspClient Deserialization', () => {
335333
const model = genericResponse.model;
336334

337335
const EXPECTED_TRACE_MAX_RANGE = "[1571171542231247219,1571171543252848866]";
338-
const EXPECTED_HEADERS = [ { name: 'Label', tooltip: '' },
339-
{ name: 'Minimum', tooltip: '' },
336+
const EXPECTED_HEADERS = [ { name: 'Label', tooltip: '' },
337+
{ name: 'Minimum', tooltip: '' },
340338
{ name: 'Maximum', tooltip: '' },
341339
{ name: 'Average', tooltip: '' },
342340
{ name: 'Std Dev', tooltip: '' },

tsp-typescript-client/tsconfig.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@
1212
"alwaysStrict": true,
1313
"strictNullChecks": true,
1414
"skipLibCheck": true,
15-
"plugins": [
16-
{
17-
"name": "tslint-language-service"
18-
}
19-
],
2015
"outDir": "lib",
2116
"rootDir": "src",
2217
"noUnusedLocals": true

0 commit comments

Comments
 (0)