uhh

Author: mmaietta

packages/app-builder-lib/src/asar/asarUtil.ts

@@ -144,7 +144,8 @@ export class AsarPackager {
     }
 
     const realPathFile = await fs.realpath(file)
-    const isOutsidePackage = path.relative(fileSet.src, realPathFile).startsWith("..")
+    const realPathRelative = path.relative(fileSet.src, realPathFile)
+    const isOutsidePackage = realPathRelative.startsWith("..")
     if (isOutsidePackage) {
       log.error({ source: log.filePath(file), realPathFile: log.filePath(realPathFile) }, `unable to copy, file is symlinked outside the package`)
       throw new Error(`Cannot copy file (${path.basename(file)}) symlinked to file (${path.basename(realPathFile)}) outside the package as that violates asar security integrity`)

test/src/globTest.ts

@@ -132,7 +132,7 @@ test.ifNotWindows("outside symlink", ({ expect }) =>
   )
 )
 
-test.only("two package nested symlink", ({ expect }) =>
+test.ifNotWindows("two package nested symlink", ({ expect }) =>
   appTwo(
     expect,
     {