Skip to content

Commit bfb5119

Browse files
committed
Remove include compat
1 parent a65f141 commit bfb5119

File tree

4 files changed

+5
-17
lines changed

4 files changed

+5
-17
lines changed

rest_framework/compat.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -305,15 +305,6 @@ def set_rollback():
305305
pass
306306

307307

308-
# TODO: Remove
309-
def include(module, namespace=None, app_name=None):
310-
from django.conf.urls import include
311-
if django.VERSION < (1,9):
312-
return include(module, namespace, app_name)
313-
else:
314-
return include((module, app_name), namespace)
315-
316-
317308
def authenticate(request=None, **credentials):
318309
from django.contrib.auth import authenticate
319310
if django.VERSION < (1, 11):

rest_framework/urlpatterns.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
from __future__ import unicode_literals
22

3-
from django.conf.urls import url
3+
from django.conf.urls import include, url
44

5-
from rest_framework.compat import RegexURLResolver, include
5+
from rest_framework.compat import RegexURLResolver
66
from rest_framework.settings import api_settings
77

88

@@ -19,8 +19,7 @@ def apply_suffix_patterns(urlpatterns, suffix_pattern, suffix_required):
1919
patterns = apply_suffix_patterns(urlpattern.url_patterns,
2020
suffix_pattern,
2121
suffix_required)
22-
ret.append(url(regex, include(patterns, namespace, app_name), kwargs))
23-
22+
ret.append(url(regex, include((patterns, app_name), namespace), kwargs))
2423
else:
2524
# Regular URL pattern
2625
regex = urlpattern.regex.pattern.rstrip('$').rstrip('/') + suffix_pattern

tests/test_routers.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,12 @@
33
from collections import namedtuple
44

55
import pytest
6-
from django.conf.urls import url
6+
from django.conf.urls import include, url
77
from django.core.exceptions import ImproperlyConfigured
88
from django.db import models
99
from django.test import TestCase, override_settings
1010

1111
from rest_framework import permissions, serializers, viewsets
12-
from rest_framework.compat import include
1312
from rest_framework.decorators import detail_route, list_route
1413
from rest_framework.response import Response
1514
from rest_framework.routers import DefaultRouter, SimpleRouter

tests/test_versioning.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
import pytest
2-
from django.conf.urls import url
2+
from django.conf.urls import include, url
33
from django.test import override_settings
44

55
from rest_framework import serializers, status, versioning
6-
from rest_framework.compat import include
76
from rest_framework.decorators import APIView
87
from rest_framework.relations import PKOnlyObject
98
from rest_framework.response import Response

0 commit comments

Comments
 (0)