From fab9d1c9356d0875af2ba01fa7b804c3b6c901d8 Mon Sep 17 00:00:00 2001 From: Karl Horky Date: Fri, 17 Dec 2021 19:55:48 +0100 Subject: [PATCH 1/3] Avoid no-floating-promises ESLint problem --- .../template/src/reportWebVitals.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/packages/cra-template/template/src/reportWebVitals.js b/packages/cra-template/template/src/reportWebVitals.js index 5253d3ad9e6..c9559b5f77b 100644 --- a/packages/cra-template/template/src/reportWebVitals.js +++ b/packages/cra-template/template/src/reportWebVitals.js @@ -1,12 +1,14 @@ -const reportWebVitals = onPerfEntry => { +const reportWebVitals = (onPerfEntry) => { if (onPerfEntry && onPerfEntry instanceof Function) { - import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => { - getCLS(onPerfEntry); - getFID(onPerfEntry); - getFCP(onPerfEntry); - getLCP(onPerfEntry); - getTTFB(onPerfEntry); - }); + import('web-vitals') + .then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => { + getCLS(onPerfEntry); + getFID(onPerfEntry); + getFCP(onPerfEntry); + getLCP(onPerfEntry); + getTTFB(onPerfEntry); + }) + .catch(() => {}); } }; From 14efbeae9c57fc4a0a41c103b5ee5323256711f8 Mon Sep 17 00:00:00 2001 From: Karl Horky Date: Fri, 17 Dec 2021 19:59:21 +0100 Subject: [PATCH 2/3] Avoid no-floating-promises ESLint problem --- .../template/src/reportWebVitals.ts | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/packages/cra-template-typescript/template/src/reportWebVitals.ts b/packages/cra-template-typescript/template/src/reportWebVitals.ts index 49a2a16e0fb..d0c20872f95 100644 --- a/packages/cra-template-typescript/template/src/reportWebVitals.ts +++ b/packages/cra-template-typescript/template/src/reportWebVitals.ts @@ -2,13 +2,15 @@ import { ReportHandler } from 'web-vitals'; const reportWebVitals = (onPerfEntry?: ReportHandler) => { if (onPerfEntry && onPerfEntry instanceof Function) { - import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => { - getCLS(onPerfEntry); - getFID(onPerfEntry); - getFCP(onPerfEntry); - getLCP(onPerfEntry); - getTTFB(onPerfEntry); - }); + import('web-vitals') + .then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => { + getCLS(onPerfEntry); + getFID(onPerfEntry); + getFCP(onPerfEntry); + getLCP(onPerfEntry); + getTTFB(onPerfEntry); + }) + .catch(() => {}); } }; From 39a4695d2bd5515e42669c283bcf206602f3a8f0 Mon Sep 17 00:00:00 2001 From: Karl Horky Date: Thu, 13 Jan 2022 15:42:47 +0100 Subject: [PATCH 3/3] Log error to console --- .../cra-template-typescript/template/src/reportWebVitals.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/cra-template-typescript/template/src/reportWebVitals.ts b/packages/cra-template-typescript/template/src/reportWebVitals.ts index d0c20872f95..ef9636e33a6 100644 --- a/packages/cra-template-typescript/template/src/reportWebVitals.ts +++ b/packages/cra-template-typescript/template/src/reportWebVitals.ts @@ -10,7 +10,9 @@ const reportWebVitals = (onPerfEntry?: ReportHandler) => { getLCP(onPerfEntry); getTTFB(onPerfEntry); }) - .catch(() => {}); + .catch((err) => { + console.error(err); + }); } };