From ec184548240114a538305f83be2c255001f9eb92 Mon Sep 17 00:00:00 2001 From: Ryan Sullivan Date: Sun, 26 Feb 2017 07:00:29 -0800 Subject: [PATCH 1/2] Override Jest config collectCoverageFrom with package.json --- packages/react-scripts/utils/createJestConfig.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/react-scripts/utils/createJestConfig.js b/packages/react-scripts/utils/createJestConfig.js index f1c67c018f1..2fc9bd1eb3c 100644 --- a/packages/react-scripts/utils/createJestConfig.js +++ b/packages/react-scripts/utils/createJestConfig.js @@ -45,5 +45,9 @@ module.exports = (resolve, rootDir, isEjecting) => { if (rootDir) { config.rootDir = rootDir; } + const packageConfig = require(paths.appPackageJson).jest; + if (packageConfig) { + config.collectCoverageFrom = packageConfig.collectCoverageFrom || config.collectCoverageFrom; + } return config; }; From 7cd994090eea89b5bbe5bf7fed67d6eafa27b17f Mon Sep 17 00:00:00 2001 From: Ryan Sullivan Date: Sun, 26 Feb 2017 15:33:33 -0800 Subject: [PATCH 2/2] Set Chrome userDataDir to be under .vscode folder --- packages/react-scripts/template/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/template/README.md b/packages/react-scripts/template/README.md index 1f4f59b4e47..e290b935625 100644 --- a/packages/react-scripts/template/README.md +++ b/packages/react-scripts/template/README.md @@ -269,7 +269,7 @@ Then add the block below to your `launch.json` file and put it inside the `.vsco "request": "launch", "url": "http://localhost:3000", "webRoot": "${workspaceRoot}/src", - "userDataDir": "${workspaceRoot}/.chrome", + "userDataDir": "${workspaceRoot}/.vscode/chrome", "sourceMapPathOverrides": { "webpack:///src/*": "${webRoot}/*" }