From ef30a8a1d8f16ce24fc9cdd5ecd87c2a4c951d3d Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Thu, 29 Jun 2017 16:20:18 +0100 Subject: [PATCH 1/5] Bump eslint-plugin-jsx-a11y --- packages/eslint-config-react-app/index.js | 2 +- packages/eslint-config-react-app/package.json | 2 +- packages/react-scripts/package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 7298a8c3b3d..8581880a54a 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -272,13 +272,13 @@ module.exports = { 'jsx-a11y/accessible-emoji': 'warn', 'jsx-a11y/alt-text': 'warn', 'jsx-a11y/anchor-has-content': 'warn', + 'jsx-a11y/anchor-is-valid': 'warn', 'jsx-a11y/aria-activedescendant-has-tabindex': 'warn', 'jsx-a11y/aria-props': 'warn', 'jsx-a11y/aria-proptypes': 'warn', 'jsx-a11y/aria-role': 'warn', 'jsx-a11y/aria-unsupported-elements': 'warn', 'jsx-a11y/heading-has-content': 'warn', - 'jsx-a11y/href-no-hash': 'warn', 'jsx-a11y/iframe-has-title': 'warn', 'jsx-a11y/img-redundant-alt': 'warn', 'jsx-a11y/no-access-key': 'warn', diff --git a/packages/eslint-config-react-app/package.json b/packages/eslint-config-react-app/package.json index cd36a70e5cb..fd80c5d1efc 100644 --- a/packages/eslint-config-react-app/package.json +++ b/packages/eslint-config-react-app/package.json @@ -15,7 +15,7 @@ "eslint": "^3.19.0", "eslint-plugin-flowtype": "^2.33.0", "eslint-plugin-import": "^2.2.0", - "eslint-plugin-jsx-a11y": "^5.0.3", + "eslint-plugin-jsx-a11y": "^6.0.2", "eslint-plugin-react": "^7.0.1" } } diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index ef3ba4881b7..edcc144c622 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -37,7 +37,7 @@ "eslint-loader": "1.7.1", "eslint-plugin-flowtype": "2.34.0", "eslint-plugin-import": "2.2.0", - "eslint-plugin-jsx-a11y": "5.0.3", + "eslint-plugin-jsx-a11y": "6.0.2", "eslint-plugin-react": "7.1.0", "extract-text-webpack-plugin": "2.1.2", "file-loader": "0.11.2", From 807548884228a2f6717dda461225ec68985d88da Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Thu, 29 Jun 2017 17:04:00 +0100 Subject: [PATCH 2/5] Update index.js --- packages/eslint-config-react-app/index.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 8581880a54a..0f49662cc3a 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -272,7 +272,10 @@ module.exports = { 'jsx-a11y/accessible-emoji': 'warn', 'jsx-a11y/alt-text': 'warn', 'jsx-a11y/anchor-has-content': 'warn', - 'jsx-a11y/anchor-is-valid': 'warn', + 'jsx-a11y/anchor-is-valid': [ + 'warn', + aspects: ['noHref', 'invalidHref'] + ], 'jsx-a11y/aria-activedescendant-has-tabindex': 'warn', 'jsx-a11y/aria-props': 'warn', 'jsx-a11y/aria-proptypes': 'warn', From 0e05c9e324d834d72256bf3c764a70d5cb2ac4ff Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Thu, 29 Jun 2017 20:09:28 +0100 Subject: [PATCH 3/5] Update index.js --- packages/eslint-config-react-app/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 0f49662cc3a..98f0ac6dac8 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -274,7 +274,9 @@ module.exports = { 'jsx-a11y/anchor-has-content': 'warn', 'jsx-a11y/anchor-is-valid': [ 'warn', - aspects: ['noHref', 'invalidHref'] + { + aspects: ['noHref', 'invalidHref'], + }, ], 'jsx-a11y/aria-activedescendant-has-tabindex': 'warn', 'jsx-a11y/aria-props': 'warn', From 51854ec5e44527de0a3dd09b909063fd919ca77c Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Sat, 1 Jul 2017 00:06:33 +0100 Subject: [PATCH 4/5] Update package.json --- packages/react-error-overlay/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-error-overlay/package.json b/packages/react-error-overlay/package.json index f29aedd0f73..b38140dc693 100644 --- a/packages/react-error-overlay/package.json +++ b/packages/react-error-overlay/package.json @@ -47,7 +47,7 @@ "eslint-config-react-app": "^1.0.5", "eslint-plugin-flowtype": "2.33.0", "eslint-plugin-import": "2.2.0", - "eslint-plugin-jsx-a11y": "5.0.3", + "eslint-plugin-jsx-a11y": "6.0.2", "eslint-plugin-react": "7.0.1", "flow-bin": "0.46.0", "jest": "20.0.1", From 4ae01dac8a9137dfdd6e8c0223d2f2d085c613d5 Mon Sep 17 00:00:00 2001 From: Dan Date: Fri, 12 Jan 2018 22:28:56 +0000 Subject: [PATCH 5/5] Don't use links for non-linky things --- .../src/containers/CompileErrorContainer.js | 4 ++-- packages/react-error-overlay/src/containers/StackFrame.js | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/react-error-overlay/src/containers/CompileErrorContainer.js b/packages/react-error-overlay/src/containers/CompileErrorContainer.js index 9d1e399fd10..3e9d4611860 100644 --- a/packages/react-error-overlay/src/containers/CompileErrorContainer.js +++ b/packages/react-error-overlay/src/containers/CompileErrorContainer.js @@ -32,14 +32,14 @@ class CompileErrorContainer extends PureComponent { return (
- editorHandler(errLoc) : null } style={canOpenInEditor ? codeAnchorStyle : null} > - +