From 58ac33ea8f96c5e8eb13c7bb96b3e506d155eafc Mon Sep 17 00:00:00 2001 From: Min ho Kim Date: Fri, 12 Jul 2019 05:27:23 +1000 Subject: [PATCH] Fix typos --- CHANGELOG-1.x.md | 4 ++-- azure-pipelines.yml | 4 ++-- packages/react-error-overlay/src/utils/unmapper.js | 2 +- packages/react-scripts/config/webpack.config.js | 4 ++-- tasks/e2e-installs.sh | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/CHANGELOG-1.x.md b/CHANGELOG-1.x.md index ae2725af297..be64a067a8c 100644 --- a/CHANGELOG-1.x.md +++ b/CHANGELOG-1.x.md @@ -482,7 +482,7 @@ yarn add --exact react-scripts@1.0.16 - [#3150](https://github.com/facebook/create-react-app/pull/3150) Remove an useless negation in `registerServiceWorker.js`. ([@dunglas](https://github.com/dunglas)) - [#3158](https://github.com/facebook/create-react-app/pull/3158) Remove `output.path` from dev webpack config. ([@nikolas](https://github.com/nikolas)) - - [#3281](https://github.com/facebook/create-react-app/pull/3281) Add a workaround for Uglify incompatiblity with Safari 10.0 in the future. ([@satyavh](https://github.com/satyavh)) + - [#3281](https://github.com/facebook/create-react-app/pull/3281) Add a workaround for Uglify incompatibility with Safari 10.0 in the future. ([@satyavh](https://github.com/satyavh)) - [#3146](https://github.com/facebook/create-react-app/pull/3146) Fix `reason-react` support. ([@lpalmes](https://github.com/lpalmes)) - [#3236](https://github.com/facebook/create-react-app/pull/3236) Update `style-loader` and disable inclusion of its HMR code in builds. ([@insin](https://github.com/insin)) - [#3246](https://github.com/facebook/create-react-app/pull/3246) Update `url-loader` to 0.6.2 for mime ReDoS vulnerability. ([@d3viant0ne](https://github.com/d3viant0ne)) @@ -1443,7 +1443,7 @@ yarn add --dev --exact react-scripts@1.0.1 ## 1.0.0 (May 18, 2017) -We’ve been working on this release for the past few months, and there are many big impovements, from migrating to webpack 2 to a brand new runtime error overlay and built-in support for Progressive Web Apps. +We’ve been working on this release for the past few months, and there are many big improvements, from migrating to webpack 2 to a brand new runtime error overlay and built-in support for Progressive Web Apps. So instead of just enumerating them here, we decided to write a blog post about all the new features.
Check it out: **[What’s New in Create React App](https://facebook.github.io/react/blog/2017/05/18/whats-new-in-create-react-app.html)**. diff --git a/azure-pipelines.yml b/azure-pipelines.yml index c51be42da86..1f770cc7105 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -12,7 +12,7 @@ variables: NPM_CONFIG_CACHE: $(Build.SourcesDirectory)/../npm-cache # Sets TEMP to be on the same drive as the cloned source on Windows. This avoids test scripts that "cd" into a directory under TEMP from failing because this directory is on a different drive from the current directory. VSTS_OVERWRITE_TEMP: True - # Override Verdaccio package to use. This is temoporary and is needed to avoid socket timeouts on hosted Windows agent (on Azure). This also changes Verdaccio to return a 503 (service unavailable) instead of a 404 (not found) when the connection to the uplink timesout. + # Override Verdaccio package to use. This is temporary and is needed to avoid socket timeouts on hosted Windows agent (on Azure). This also changes Verdaccio to return a 503 (service unavailable) instead of a 404 (not found) when the connection to the uplink timesout. VERDACCIO_PACKAGE: https://github.com/willsmythe/verdaccio/releases/download/create-react-app/verdaccio-4.0.0-alpha.8.tgz # ****************************************************************************** @@ -67,7 +67,7 @@ jobs: # Old Node test suite # ****************************************************************************** - job: OldNode - pool: + pool: vmImage: ubuntu-16.04 steps: - task: NodeTool@0 diff --git a/packages/react-error-overlay/src/utils/unmapper.js b/packages/react-error-overlay/src/utils/unmapper.js index c61fad4fb6c..4c95ab4d7b3 100644 --- a/packages/react-error-overlay/src/utils/unmapper.js +++ b/packages/react-error-overlay/src/utils/unmapper.js @@ -12,7 +12,7 @@ import { getLinesAround } from './getLinesAround'; import path from 'path'; function count(search: string, string: string): number { - // Count starts at -1 becuse a do-while loop always runs at least once + // Count starts at -1 because a do-while loop always runs at least once let count = -1, index = -1; do { diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index 771b06c94d1..7543dbbe203 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -197,7 +197,7 @@ module.exports = function(webpackEnv) { terserOptions: { parse: { // we want terser to parse ecma 8 code. However, we don't want it - // to apply any minfication steps that turns valid ecma 5 code + // to apply any minification steps that turns valid ecma 5 code // into invalid ecma 5 code. This is why the 'compress' and 'output' // sections only apply transformations that are ecma 5 safe // https://github.com/facebook/create-react-app/pull/4234 @@ -213,7 +213,7 @@ module.exports = function(webpackEnv) { comparisons: false, // Disabled because of an issue with Terser breaking valid code: // https://github.com/facebook/create-react-app/issues/5250 - // Pending futher investigation: + // Pending further investigation: // https://github.com/terser-js/terser/issues/120 inline: 2, }, diff --git a/tasks/e2e-installs.sh b/tasks/e2e-installs.sh index 27577cdef0d..f083f2dd09b 100755 --- a/tasks/e2e-installs.sh +++ b/tasks/e2e-installs.sh @@ -213,7 +213,7 @@ exists node_modules/react-scripts-fork # ****************************************************************************** cd "$temp_app_path" -# we will install a non-existing package to simulate a failed installataion. +# we will install a non-existing package to simulate a failed installation. npx create-react-app test-app-should-not-exist --scripts-version=`date +%s` || true # confirm that the project files were deleted test ! -e test-app-should-not-exist/package.json @@ -226,7 +226,7 @@ test ! -d test-app-should-not-exist/node_modules cd "$temp_app_path" mkdir test-app-should-remain echo '## Hello' > ./test-app-should-remain/README.md -# we will install a non-existing package to simulate a failed installataion. +# we will install a non-existing package to simulate a failed installation. npx create-react-app test-app-should-remain --scripts-version=`date +%s` || true # confirm the file exist test -e test-app-should-remain/README.md