build_changed.ts/test_changed.ts: replace process.exit() with just letting the exception bubble up, to avoid truncating output

Author: dconeybe

scripts/ci-test/build_changed.ts

@@ -63,41 +63,36 @@ async function buildForTests(
   config: TestConfig,
   { buildAll = false }: Options
 ) {
-  try {
-    const testTasks = filterTasks(await getTestTasks(), config);
-    // print tasks for info
-    logTasks(testTasks);
-    if (testTasks.length === 0) {
-      console.log(chalk`{green No test tasks. Skipping all builds }`);
-      return;
-    }
+  const testTasks = filterTasks(await getTestTasks(), config);
+  // print tasks for info
+  logTasks(testTasks);
+  if (testTasks.length === 0) {
+    console.log(chalk`{green No test tasks. Skipping all builds }`);
+    return;
+  }
 
-    // build all and return
-    if (buildAll) {
-      await spawn('yarn', ['build'], { stdio: 'inherit', cwd: root });
-      return;
-    }
+  // build all and return
+  if (buildAll) {
+    await spawn('yarn', ['build'], { stdio: 'inherit', cwd: root });
+    return;
+  }
 
-    const lernaCmd = ['lerna', 'run'];
-    console.log(chalk`{blue Running build in:}`);
-    for (const task of testTasks) {
-      if (task.reason === TestReason.Changed) {
-        console.log(chalk`{yellow ${task.pkgName} (contains modified files)}`);
-      } else if (task.reason === TestReason.Dependent) {
-        console.log(
-          chalk`{yellow ${task.pkgName} (depends on modified files)}`
-        );
-      } else {
-        console.log(chalk`{yellow ${task.pkgName} (running all tests)}`);
-      }
-      lernaCmd.push('--scope');
-      lernaCmd.push(task.pkgName);
+  const lernaCmd = ['lerna', 'run'];
+  console.log(chalk`{blue Running build in:}`);
+  for (const task of testTasks) {
+    if (task.reason === TestReason.Changed) {
+      console.log(chalk`{yellow ${task.pkgName} (contains modified files)}`);
+    } else if (task.reason === TestReason.Dependent) {
+      console.log(
+        chalk`{yellow ${task.pkgName} (depends on modified files)}`
+      );
+    } else {
+      console.log(chalk`{yellow ${task.pkgName} (running all tests)}`);
     }
-
-    lernaCmd.push('--include-dependencies', 'build');
-    await spawn('npx', lernaCmd, { stdio: 'inherit', cwd: root });
-  } catch (e) {
-    console.error(chalk`{red ${e}}`);
-    process.exit(1);
+    lernaCmd.push('--scope');
+    lernaCmd.push(task.pkgName);
   }
+
+  lernaCmd.push('--include-dependencies', 'build');
+  await spawn('npx', lernaCmd, { stdio: 'inherit', cwd: root });
 }

scripts/ci-test/test_changed.ts

@@ -49,37 +49,31 @@ const config = testConfig[inputTestConfigName]!;
 runTests(config);
 
 async function runTests(config: TestConfig) {
-  try {
-    const testTasks = filterTasks(await getTestTasks(), config);
+  const testTasks = filterTasks(await getTestTasks(), config);
 
-    // print tasks for info
-    logTasks(testTasks);
-    if (testTasks.length === 0) {
-      chalk`{green No test tasks. Skipping all tests }`;
-      process.exit(0);
-    }
+  // print tasks for info
+  logTasks(testTasks);
+  if (testTasks.length === 0) {
+    chalk`{green No test tasks. Skipping all tests }`;
+    process.exit(0);
+  }
 
-    const lernaCmd = ['lerna', 'run', '--concurrency', '4'];
-    console.log(chalk`{blue Running tests in:}`);
-    for (const task of testTasks) {
-      if (task.reason === TestReason.Changed) {
-        console.log(chalk`{yellow ${task.pkgName} (contains modified files)}`);
-      } else if (task.reason === TestReason.Dependent) {
-        console.log(
-          chalk`{yellow ${task.pkgName} (depends on modified files)}`
-        );
-      } else {
-        console.log(chalk`{yellow ${task.pkgName} (running all tests)}`);
-      }
-      lernaCmd.push('--scope');
-      lernaCmd.push(task.pkgName);
+  const lernaCmd = ['lerna', 'run', '--concurrency', '4'];
+  console.log(chalk`{blue Running tests in:}`);
+  for (const task of testTasks) {
+    if (task.reason === TestReason.Changed) {
+      console.log(chalk`{yellow ${task.pkgName} (contains modified files)}`);
+    } else if (task.reason === TestReason.Dependent) {
+      console.log(
+        chalk`{yellow ${task.pkgName} (depends on modified files)}`
+      );
+    } else {
+      console.log(chalk`{yellow ${task.pkgName} (running all tests)}`);
     }
-
-    lernaCmd.push(testCommand);
-    await spawn('npx', lernaCmd, { stdio: 'inherit', cwd: root });
-    process.exit(0);
-  } catch (e) {
-    console.error(chalk`{red ${e}}`);
-    process.exit(1);
+    lernaCmd.push('--scope');
+    lernaCmd.push(task.pkgName);
   }
+
+  lernaCmd.push(testCommand);
+  await spawn('npx', lernaCmd, { stdio: 'inherit', cwd: root });
 }