From 52fb257df10f4e8700ee9dc61be4fba8767e057a Mon Sep 17 00:00:00 2001 From: Daniel La Rocque Date: Thu, 18 Jul 2024 10:36:38 -0400 Subject: [PATCH 1/2] Run Storage Node tests in CI The script that runs the tests in CI accepts a `-s` flag we use to pass the test command we want to run in CI. We were passing two commands, and only the first one (`test:browser`) was being run, skipping the Node tests. Now we only pass one command `test`, which runs both. --- packages/storage/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/storage/package.json b/packages/storage/package.json index f609e2b5f85..3f010239649 100644 --- a/packages/storage/package.json +++ b/packages/storage/package.json @@ -34,7 +34,7 @@ "build:deps": "lerna run --scope @firebase/storage --include-dependencies build", "dev": "rollup -c -w", "test": "run-p --npm-path npm test:browser test:node lint", - "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser test:node", + "test:ci": "node ../../scripts/run_tests_in_ci.js -s test", "test:browser:unit": "karma start --single-run --unit", "test:browser:integration": "karma start --single-run --integration", "test:browser": "karma start --single-run", From 264059eec7bfb97bd6da5858ac52be9549dace8e Mon Sep 17 00:00:00 2001 From: Daniel La Rocque Date: Wed, 21 Aug 2024 16:35:41 -0400 Subject: [PATCH 2/2] Add test:all script that doesn't lint --- packages/storage/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/storage/package.json b/packages/storage/package.json index 3f010239649..cb8fdd48a55 100644 --- a/packages/storage/package.json +++ b/packages/storage/package.json @@ -34,7 +34,8 @@ "build:deps": "lerna run --scope @firebase/storage --include-dependencies build", "dev": "rollup -c -w", "test": "run-p --npm-path npm test:browser test:node lint", - "test:ci": "node ../../scripts/run_tests_in_ci.js -s test", + "test:all": "run-p --npm-path npm test:browser test:node", + "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all", "test:browser:unit": "karma start --single-run --unit", "test:browser:integration": "karma start --single-run --integration", "test:browser": "karma start --single-run",