From a1a97970409cfff9956a5149743c1d82cd234685 Mon Sep 17 00:00:00 2001 From: khaaleoo Date: Thu, 27 Feb 2025 14:42:51 +0700 Subject: [PATCH 1/4] Fix transport service retry logic condition Modify the retry mechanism to stop when remaining tries is less than or equal to zero, improving the robustness of the retry handling. --- packages/performance/src/services/transport_service.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/performance/src/services/transport_service.ts b/packages/performance/src/services/transport_service.ts index cf5e3972972..30a1b94e926 100644 --- a/packages/performance/src/services/transport_service.ts +++ b/packages/performance/src/services/transport_service.ts @@ -72,8 +72,8 @@ export function resetTransportService(): void { function processQueue(timeOffset: number): void { setTimeout(() => { - // If there is no remainingTries left, stop retrying. - if (remainingTries === 0) { + // If there is no remaining Tries left, stop retrying. + if (remainingTries <= 0) { return; } From ab4af723b47ec5e16962af060f0432e48263fb26 Mon Sep 17 00:00:00 2001 From: khaaleoo Date: Thu, 27 Feb 2025 15:10:00 +0700 Subject: [PATCH 2/4] Minor comment clarification in transport service retry logic Update comment to improve readability of the retry mechanism condition. --- packages/performance/src/services/transport_service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/performance/src/services/transport_service.ts b/packages/performance/src/services/transport_service.ts index 30a1b94e926..8577fd3a128 100644 --- a/packages/performance/src/services/transport_service.ts +++ b/packages/performance/src/services/transport_service.ts @@ -72,7 +72,7 @@ export function resetTransportService(): void { function processQueue(timeOffset: number): void { setTimeout(() => { - // If there is no remaining Tries left, stop retrying. + // If there is no remainingTries left, stop retrying. if (remainingTries <= 0) { return; } From c165478687a8c53b88e9242b00be2855288b09de Mon Sep 17 00:00:00 2001 From: khaaleoo Date: Thu, 27 Feb 2025 16:17:57 +0700 Subject: [PATCH 3/4] Add changeset for Performance SDK retry mechanism improvement Modify the retry mechanism in the Performance SDK to stop when remaining tries is less than or equal to zero, enhancing the robustness of retry handling. --- .changeset/floppy-schools-battle.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/floppy-schools-battle.md diff --git a/.changeset/floppy-schools-battle.md b/.changeset/floppy-schools-battle.md new file mode 100644 index 00000000000..bb65c9f1258 --- /dev/null +++ b/.changeset/floppy-schools-battle.md @@ -0,0 +1,5 @@ +--- +'@firebase/performance': major +--- + +Modify the retry mechanism to stop when remaining tries is less than or equal to zero, improving the robustness of the retry handling. From 7aaaff3b8c350a8aad750cbf3d8e328265235fe4 Mon Sep 17 00:00:00 2001 From: khaaleoo Date: Sat, 1 Mar 2025 12:00:55 +0700 Subject: [PATCH 4/4] Update Performance SDK package versions for retry mechanism patch --- .changeset/floppy-schools-battle.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.changeset/floppy-schools-battle.md b/.changeset/floppy-schools-battle.md index bb65c9f1258..499b04a6672 100644 --- a/.changeset/floppy-schools-battle.md +++ b/.changeset/floppy-schools-battle.md @@ -1,5 +1,6 @@ --- -'@firebase/performance': major +'@firebase/performance': patch +'firebase': patch --- Modify the retry mechanism to stop when remaining tries is less than or equal to zero, improving the robustness of the retry handling.