[CQ] remove (stale) deploy plugin command (#7929)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [x] I signed the [CLA].

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md

Author: pq

tool/plugin/lib/plugin.dart

@@ -24,7 +24,6 @@ Future<int> main(List<String> args) async {
   runner.addCommand(LintCommand(runner));
   runner.addCommand(GradleBuildCommand(runner));
   runner.addCommand(TestCommand(runner));
-  runner.addCommand(DeployCommand(runner));
   runner.addCommand(GenerateCommand(runner));
   runner.addCommand(VerifyCommand(runner));
   runner.addCommand(RunIdeCommand(runner));
@@ -476,89 +475,6 @@ class GradleBuildCommand extends ProductCommand {
   }
 }
 
-/// Either the --release or --channel options must be provided.
-/// The permanent token is read from the file specified by Kokoro.
-class DeployCommand extends ProductCommand {
-  @override
-  final BuildCommandRunner runner;
-
-  DeployCommand(this.runner) : super('deploy');
-
-  @override
-  String get description => 'Upload the Flutter plugin to the JetBrains site.';
-
-  @override
-  Future<int> doit() async {
-    if (isReleaseMode) {
-      if (!await performReleaseChecks(this)) {
-        return 1;
-      }
-    } else if (!isDevChannel) {
-      log('Deploy must have a --release or --channel=dev argument');
-      return 1;
-    }
-
-    var token = readTokenFromKeystore('FLUTTER_KEYSTORE_NAME');
-    var value = 0;
-    var originalDir = Directory.current;
-    for (var spec in specs) {
-      if (spec.channel != channel) continue;
-      var filePath = releasesFilePath(spec);
-      log("uploading $filePath");
-      var file = File(filePath);
-      changeDirectory(file.parent);
-      var pluginNumber = pluginRegistryIds[spec.pluginId];
-      value = await upload(
-        p.basename(file.path),
-        pluginNumber!,
-        token,
-        spec.channel,
-      );
-      if (value != 0) {
-        return value;
-      }
-    }
-    changeDirectory(originalDir);
-    return value;
-  }
-
-  void changeDirectory(Directory dir) {
-    Directory.current = dir.path;
-  }
-
-  Future<int> upload(
-    String filePath,
-    String pluginNumber,
-    String token,
-    String channel,
-  ) async {
-    if (!File(filePath).existsSync()) {
-      throw 'File not found: $filePath';
-    }
-    // See https://plugins.jetbrains.com/docs/marketplace/plugin-upload.html#PluginUploadAPI-POST
-    // Trying to run curl directly doesn't work; something odd happens to the quotes.
-    var cmd = '''
-curl
--i
---header "Authorization: Bearer $token"
--F pluginId=$pluginNumber
--F file=@$filePath
--F channel=$channel
-https://plugins.jetbrains.com/plugin/uploadPlugin
-''';
-
-    var args = ['-c', cmd.split('\n').join(' ')];
-    final processResult = await Process.run('sh', args);
-    if (processResult.exitCode != 0) {
-      log('Upload failed: ${processResult.stderr} for file: $filePath');
-    }
-    final out = processResult.stdout as String;
-    var message = out.trim().split('\n').last.trim();
-    log(message);
-    return processResult.exitCode;
-  }
-}
-
 /// Generate the plugin.xml from the plugin.xml.template file. If the --release
 /// argument is given, create a git branch and commit the new file to it,
 /// assuming the release checks pass.

tool/plugin/lib/runner.dart

@@ -12,10 +12,10 @@ import 'util.dart';
 
 class BuildCommandRunner extends CommandRunner<int> {
   BuildCommandRunner()
-    : super(
-        'plugin',
-        'A script to build, test, and deploy the Flutter IntelliJ plugin.',
-      ) {
+      : super(
+          'plugin',
+          'A script to build and test the Flutter IntelliJ plugin.',
+        ) {
     argParser.addOption(
       'release',
       abbr: 'r',

tool/plugin/test/plugin_test.dart

@@ -21,10 +21,6 @@ void main() {
       expect(TestCommand(BuildCommandRunner()).name, "test");
     });
 
-    test('deploy', () {
-      expect(DeployCommand(BuildCommandRunner()).name, "deploy");
-    });
-
     test('generate', () {
       expect(GenerateCommand(BuildCommandRunner()).name, "generate");
     });
@@ -87,13 +83,6 @@ void main() {
       });
     });
 
-    test('deploy', () async {
-      var runner = makeTestRunner();
-      await runner.run(["-r19", "-d../..", "deploy"]).whenComplete(() {
-        buildSpecAssertions(runner, "deploy");
-      });
-    });
-
     test('verify', () async {
       var runner = makeTestRunner();
       await runner.run(["-r19", "-d../..", "verify"]).whenComplete(() {
@@ -102,75 +91,6 @@ void main() {
     });
   });
 
-  group('release', () {
-    test('simple', () async {
-      var runner = makeTestRunner();
-      late TestDeployCommand cmd;
-      await runner.run(["-r19", "-d../..", "deploy"]).whenComplete(() {
-        cmd = (runner.commands['deploy'] as TestDeployCommand);
-      });
-      expect(cmd.isReleaseValid, true);
-    });
-
-    test('minor', () async {
-      var runner = makeTestRunner();
-      late TestDeployCommand cmd;
-      await runner.run(["-r19.2", "-d../..", "deploy"]).whenComplete(() {
-        cmd = (runner.commands['deploy'] as TestDeployCommand);
-      });
-      expect(cmd.isReleaseValid, true);
-    });
-
-    test('patch invalid', () async {
-      var runner = makeTestRunner();
-      late TestDeployCommand cmd;
-      await runner.run(["-r19.2.1", "-d../..", "deploy"]).whenComplete(() {
-        cmd = (runner.commands['deploy'] as TestDeployCommand);
-      });
-      expect(cmd.isReleaseValid, false);
-    });
-
-    test('non-numeric', () async {
-      var runner = makeTestRunner();
-      late TestDeployCommand cmd;
-      await runner.run(["-rx19.2", "-d../..", "deploy"]).whenComplete(() {
-        cmd = (runner.commands['deploy'] as TestDeployCommand);
-      });
-      expect(cmd.isReleaseValid, false);
-    });
-  });
-
-  group('deploy', () {
-    test('clean', () async {
-      var dir = Directory.current;
-      var runner = makeTestRunner();
-      await runner
-          .run(["-r=19", "-d../..", "deploy", "--no-as", "--no-ij"])
-          .whenComplete(() {
-            expect(Directory.current.path, equals(dir.path));
-          });
-    });
-
-    test('without --release', () async {
-      var runner = makeTestRunner();
-      late TestDeployCommand cmd;
-      await runner.run(["-d../..", "deploy"]).whenComplete(() {
-        cmd = (runner.commands['deploy'] as TestDeployCommand);
-      });
-      expect(cmd.paths, orderedEquals([]));
-    });
-
-    test('release paths', () async {
-      var runner = makeTestRunner();
-      late TestDeployCommand cmd;
-      await runner.run(["--release=19", "-d../..", "deploy"]).whenComplete(() {
-        cmd = (runner.commands['deploy'] as TestDeployCommand);
-      });
-      var specs = cmd.specs.where((s) => s.isStableChannel).toList();
-      expect(cmd.paths.length, specs.length);
-    });
-  });
-
   group('build', () {
     test('plugin.xml', () async {
       var runner = makeTestRunner();
@@ -255,41 +175,11 @@ BuildCommandRunner makeTestRunner() {
   var runner = BuildCommandRunner();
   runner.addCommand(TestMakeCommand(runner));
   runner.addCommand(TestTestCommand(runner));
-  runner.addCommand(TestDeployCommand(runner));
   runner.addCommand(TestGenCommand(runner));
   runner.addCommand(TestVerifyCommand(runner));
   return runner;
 }
 
-class TestDeployCommand extends DeployCommand {
-  List<String> paths = <String>[];
-  List<String> plugins = <String>[];
-
-  TestDeployCommand(super.runner);
-
-  @override
-  bool get isTesting => true;
-
-  @override
-  void changeDirectory(Directory dir) {}
-
-  String readTokenFile() {
-    return "token";
-  }
-
-  @override
-  Future<int> upload(
-    String filePath,
-    String pluginNumber,
-    String token,
-    String channel,
-  ) {
-    paths.add(filePath);
-    plugins.add(pluginNumber);
-    return Future(() => 0);
-  }
-}
-
 class TestGenCommand extends GenerateCommand {
   TestGenCommand(super.runner);