Skip to content

Commit 4f3f223

Browse files
authored
ignore gradle.properties and .idea/misc.xml to reduce friction creating prs (#7928)
These hold configuration based on the current SDKs you are building with, and **probably** don't make sense to commit :).
1 parent 78f85d4 commit 4f3f223

File tree

4 files changed

+7
-30
lines changed

4 files changed

+7
-30
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,6 @@ lib/kotlin*
4343
gradle
4444
gradlew
4545
gradlew.bat
46+
# User specific configuration based on current Intellij SDKs.
47+
gradle.properties
48+
.idea/misc.xml

.idea/misc.xml

Lines changed: 0 additions & 14 deletions
This file was deleted.

gradle.properties

Lines changed: 0 additions & 14 deletions
This file was deleted.

tool/plugin/lib/runner.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ org.gradle.parallel=true
7878
org.gradle.jvmargs=-Xms1024m -Xmx4048m
7979
''';
8080
final propertiesFile = File("$rootPath/gradle.properties");
81-
final source = propertiesFile.readAsStringSync();
81+
final source = propertiesFile.existsSync()
82+
? propertiesFile.readAsStringSync()
83+
: null;
8284
propertiesFile.writeAsStringSync(contents);
8385
int result;
8486
// Using the Gradle daemon causes a strange problem.
@@ -99,7 +101,7 @@ org.gradle.jvmargs=-Xms1024m -Xmx4048m
99101
}
100102
}
101103
} finally {
102-
propertiesFile.writeAsStringSync(source);
104+
if (source != null) propertiesFile.writeAsStringSync(source);
103105
}
104106
return result;
105107
}

0 commit comments

Comments
 (0)