Skip to content

Commit 56c9fcb

Browse files
authored
fix(nuxt): Only add OTel alias in dev mode (#16756)
Only add alias in dev mode and don't override an existing one so people can still add their own alias. fixes #16742 reference: #15204
1 parent 6ecefd1 commit 56c9fcb

File tree

2 files changed

+22
-4
lines changed

2 files changed

+22
-4
lines changed

packages/nuxt/src/vite/utils.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,15 @@ export function constructFunctionReExport(pathWithQuery: string, entryId: string
191191
* @see https://nuxt.com/docs/guide/concepts/esm#aliasing-libraries
192192
*/
193193
export function addOTelCommonJSImportAlias(nuxt: Nuxt): void {
194+
if (!nuxt.options.dev) {
195+
return;
196+
}
197+
194198
if (!nuxt.options.alias) {
195199
nuxt.options.alias = {};
196200
}
197201

198-
nuxt.options.alias['@opentelemetry/resources'] = '@opentelemetry/resources/build/src/index.js';
202+
if (!nuxt.options.alias['@opentelemetry/resources']) {
203+
nuxt.options.alias['@opentelemetry/resources'] = '@opentelemetry/resources/build/src/index.js';
204+
}
199205
}

packages/nuxt/test/vite/utils.test.ts

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ export { foo_sentryWrapped as foo };
371371
describe('addOTelCommonJSImportAlias', () => {
372372
it('adds alias for @opentelemetry/resources when options.alias does not exist', () => {
373373
const nuxtMock: Nuxt = {
374-
options: {},
374+
options: { dev: true },
375375
} as unknown as Nuxt;
376376

377377
addOTelCommonJSImportAlias(nuxtMock);
@@ -384,6 +384,7 @@ describe('addOTelCommonJSImportAlias', () => {
384384
it('adds alias for @opentelemetry/resources when options.alias already exists', () => {
385385
const nuxtMock: Nuxt = {
386386
options: {
387+
dev: true,
387388
alias: {
388389
'existing-alias': 'some-path',
389390
},
@@ -398,9 +399,10 @@ describe('addOTelCommonJSImportAlias', () => {
398399
});
399400
});
400401

401-
it('overwrites existing alias for @opentelemetry/resources if already present', () => {
402+
it('does not override existing alias for @opentelemetry/resources', () => {
402403
const nuxtMock: Nuxt = {
403404
options: {
405+
dev: true,
404406
alias: {
405407
'@opentelemetry/resources': 'some-other-path',
406408
},
@@ -410,7 +412,17 @@ describe('addOTelCommonJSImportAlias', () => {
410412
addOTelCommonJSImportAlias(nuxtMock);
411413

412414
expect(nuxtMock.options.alias).toEqual({
413-
'@opentelemetry/resources': '@opentelemetry/resources/build/src/index.js',
415+
'@opentelemetry/resources': 'some-other-path',
414416
});
415417
});
418+
419+
it('does not add alias when not development mode', () => {
420+
const nuxtMock: Nuxt = {
421+
options: {},
422+
} as unknown as Nuxt;
423+
424+
addOTelCommonJSImportAlias(nuxtMock);
425+
426+
expect(nuxtMock.options.alias).toBeUndefined();
427+
});
416428
});

0 commit comments

Comments
 (0)