Set project name from build-scans.csv in scripts

Author: erichaagdev

components/scripts/lib/build-scan-online.sh

@@ -24,10 +24,14 @@ read_build_scan_metadata() {
       debug ""
     fi
 
-    while IFS=, read -r run_num field_1 field_2 field_3; do
-       base_urls[$run_num]="$field_1"
-       build_scan_urls[$run_num]="$field_2"
-       build_scan_ids[$run_num]="$field_3"
+    local run_num base_url build_scan_url build_scan_id project_name
+
+    # shellcheck disable=SC2034
+    while IFS=, read -r run_num base_url build_scan_url build_scan_id project_name; do
+       base_urls[$run_num]="${base_url}"
+       build_scan_urls[$run_num]="${build_scan_url}"
+       build_scan_ids[$run_num]="${build_scan_id}"
+       project_names[$run_num]="${project_name}"
     done <<< "${build_scan_metadata}"
   fi
 }

components/scripts/lib/build-scan-parse.sh

@@ -80,7 +80,17 @@ parse_build_scan_row() {
   while IFS=, read -r run_num field_1 field_2 field_3 field_4 field_5 field_6 field_7 field_8 field_9 field_10 field_11 field_12 field_13 field_14 field_15 field_16 field_17 field_18 field_19 field_20 field_21; do
     debug "Build Scan $field_4 is for build $run_num"
 
-    project_names[run_num]="${field_1}"
+    # The project_name should be overridden by Build Scan data if it is
+    # available. This is so that the project names displayed in the summary are
+    # consistent with what is shown in the Build Scan.
+
+    if [ -n "${field_1}" ]; then
+      project_names[run_num]="${field_1}"
+    fi
+
+    # If the following fields are already valued, then they should not be
+    # overridden by Build Scan data. For locally executed builds, this data is
+    # determined by the scripts as a result of execution.
 
     if [ -z "${base_urls[run_num]}" ]; then
       base_urls[run_num]="${field_2}"
@@ -90,8 +100,6 @@ parse_build_scan_row() {
       build_scan_urls[run_num]="${field_3}"
     fi
 
-    build_scan_ids[run_num]="${field_4}"
-
     if [ -z "${git_repos[run_num]}" ]; then
       git_repos[run_num]="${field_5}"
     fi
@@ -112,6 +120,11 @@ parse_build_scan_row() {
       build_outcomes[run_num]="${field_9}"
     fi
 
+    # The below fields are always set by Build Scan data regardless of their
+    # previous value and are always safe to override.
+
+    build_scan_ids[run_num]="${field_4}"
+
     remote_build_cache_urls[run_num]="${field_10}"
     remote_build_cache_shards[run_num]="${field_11}"