From 52057f4a0c9293dd76ec7f48a2b3d14fbc0c95ce Mon Sep 17 00:00:00 2001 From: Eric Haag Date: Tue, 11 Apr 2023 20:43:08 -0500 Subject: [PATCH 1/4] Flip condition for when brief logging is used --- components/scripts/lib/build-scan-online.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/components/scripts/lib/build-scan-online.sh b/components/scripts/lib/build-scan-online.sh index 66cd9955..e909455f 100644 --- a/components/scripts/lib/build-scan-online.sh +++ b/components/scripts/lib/build-scan-online.sh @@ -59,8 +59,9 @@ fetch_build_scans_and_build_time_metrics() { local build_scan_urls=("$@") local brief_logging - if [[ "$build_cache_metrics_only" != 'build_cache_metrics_only' ]]; then + if [[ "${build_cache_metrics_only}" == 'build_cache_metrics_only' ]]; then brief_logging="brief_logging" + else info "Fetching build scan data" fi From 713e379e9420b0509bbfd56b1da1dbdc34ddc820 Mon Sep 17 00:00:00 2001 From: Eric Haag Date: Tue, 11 Apr 2023 20:54:04 -0500 Subject: [PATCH 2/4] Update release.md --- release/changes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/changes.md b/release/changes.md index bddc62d8..214cc2c5 100644 --- a/release/changes.md +++ b/release/changes.md @@ -1 +1 @@ -- [NEW] TBD +- [FIX] Logging level when fetching Build Scan data from Gradle Enterprise is incorrect From bc208d81b5400276ee380ab9c4301c02ee924c98 Mon Sep 17 00:00:00 2001 From: Eric Haag Date: Tue, 11 Apr 2023 21:16:46 -0500 Subject: [PATCH 3/4] Use verbose logging when fetching single Build Scan --- components/scripts/lib/build-scan-online.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/scripts/lib/build-scan-online.sh b/components/scripts/lib/build-scan-online.sh index e909455f..ade7edd8 100644 --- a/components/scripts/lib/build-scan-online.sh +++ b/components/scripts/lib/build-scan-online.sh @@ -48,7 +48,7 @@ fetch_single_build_scan() { local build_scan_url="$1" local build_scan_data - build_scan_data="$(fetch_build_scan_data brief_logging "${build_scan_url}")" + build_scan_data="$(fetch_build_scan_data verbose_logging "${build_scan_url}")" parse_single_build_scan "${build_scan_data}" } From 98bef4add67aac7d6bc04eb223b41fffffb22b9d Mon Sep 17 00:00:00 2001 From: Eric Haag Date: Tue, 11 Apr 2023 22:22:02 -0500 Subject: [PATCH 4/4] Wrap verbose_logging in quotes --- components/scripts/lib/build-scan-online.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/scripts/lib/build-scan-online.sh b/components/scripts/lib/build-scan-online.sh index ade7edd8..c33574ed 100644 --- a/components/scripts/lib/build-scan-online.sh +++ b/components/scripts/lib/build-scan-online.sh @@ -48,7 +48,7 @@ fetch_single_build_scan() { local build_scan_url="$1" local build_scan_data - build_scan_data="$(fetch_build_scan_data verbose_logging "${build_scan_url}")" + build_scan_data="$(fetch_build_scan_data 'verbose_logging' "${build_scan_url}")" parse_single_build_scan "${build_scan_data}" }