Skip to content

Commit 7e2e78f

Browse files
committed
[Tests] no-named-as-default: add cases for invalid code
1 parent 53e1916 commit 7e2e78f

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

src/rules/no-named-as-default.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ module.exports = {
3535
}
3636

3737
if (!importedModule.hasDefault) {
38-
// Impossible: how could we even get here? Kept in case of unexpected regressions.
38+
// The rule is triggered for default imports/exports, so if the imported module has no default
39+
// this means we're dealing with incorrect source code anyway
3940
return;
4041
}
4142

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export const foobar = 4;

tests/src/rules/no-named-as-default.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,10 @@ ruleTester.run('no-named-as-default', rule, {
4747
test({
4848
code: 'import variable from "./no-named-as-default/misleading-re-exports.js";',
4949
}),
50+
test({
51+
// incorrect import
52+
code: 'import foobar from "./no-named-as-default/no-default-export.js";',
53+
}),
5054
// same tests, but for exports
5155
test({
5256
code: 'export something from "./no-named-as-default/re-exports.js";',
@@ -66,6 +70,10 @@ ruleTester.run('no-named-as-default', rule, {
6670
code: 'export variable from "./no-named-as-default/misleading-re-exports.js";',
6771
parser: parsers.BABEL_OLD,
6872
}),
73+
test({
74+
code: 'export foobar from "./no-named-as-default/no-default-export.js";',
75+
parser: parsers.BABEL_OLD,
76+
}),
6977

7078
...SYNTAX_CASES,
7179
),

0 commit comments

Comments
 (0)