[SYCL] non-const static variables defined outside kernel must be

forbidden in it. (fix #1)

Signed-off-by: Aleksander Fadeev <aleksander.fadeev@intel.com>

Author: fadeeval

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -10626,7 +10626,7 @@ def err_sycl_kernel_name_class_not_top_level : Error<
  "nest in a namespace: %0">;
 def err_sycl_restrict : Error<
   "SYCL kernel cannot "
-"%select{use a global variable"
+"%select{use a non-const global variable"
   "|use rtti"
   "|use a non-const static data variable"
   "|call a virtual function"

clang/lib/Sema/SemaExpr.cpp

@@ -210,6 +210,13 @@ bool Sema::DiagnoseUseOfDecl(NamedDecl *D, ArrayRef<SourceLocation> Locs,
                              bool ObjCPropertyAccess,
                              bool AvoidPartialAvailabilityChecks,
                              ObjCInterfaceDecl *ClassReceiver) {
+
+  if (isa<VarDecl>(D) && getLangOpts().SYCLIsDevice &&
+      cast<VarDecl>(D)->getStorageClass() == SC_Static &&
+      !cast<VarDecl>(D)->getType().isConstant(Context))
+    SYCLDiagIfDeviceCode(*Locs.begin(), diag::err_sycl_restrict)
+        << Sema::KernelNonConstStaticDataVariable;
+
   SourceLocation Loc = Locs.front();
   if (getLangOpts().CPlusPlus && isa<FunctionDecl>(D)) {
     // If there were any diagnostics suppressed by template argument deduction,
@@ -18450,3 +18457,4 @@ bool Sema::IsDependentFunctionNameExpr(Expr *E) {
   assert(E->isTypeDependent());
   return isa<UnresolvedLookupExpr>(E);
 }
+

clang/test/SemaSYCL/sycl-device-static-restrict.cpp

@@ -0,0 +1,22 @@
+// RUN: %clang_cc1 -verify -fsyntax-only -fsycl-is-device %s
+const int glob1 = 1;
+int glob2 = 2;
+template <typename name, typename Func>
+__attribute__((sycl_kernel)) void kernel_single_task(Func kernelFunc) {
+  // expected-note-re@+1{{called by 'kernel_single_task<fake_kernel, (lambda at {{.*}})>}}
+  kernelFunc();
+}
+
+int main() {
+  static int n = 0;
+  const static int l = 0;
+  kernel_single_task<class fake_kernel>([]() {
+  int m = l;
+  m = glob1;
+  // expected-error@+1{{SYCL kernel cannot use a non-const static data variable}}
+	m = n;
+  // expected-error@+1{{SYCL kernel cannot use a non-const global variable}}
+  m = glob2;
+  });
+  return 0;
+}