From a55def63304e1567c4fdcc35782f9af100a4573a Mon Sep 17 00:00:00 2001 From: Ross Gerbasi Date: Thu, 8 Mar 2018 14:53:19 -0600 Subject: [PATCH 1/2] real fix for sass --- src/components/site-menu/site-menu-map.ts | 2 +- src/docs-content/theming/basics.md | 2 +- .../theming/{theming-with-scss.md => theming-with-sass.md} | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename src/docs-content/theming/{theming-with-scss.md => theming-with-sass.md} (99%) diff --git a/src/components/site-menu/site-menu-map.ts b/src/components/site-menu/site-menu-map.ts index e6dd4039fb6..66a758ca4a6 100644 --- a/src/components/site-menu/site-menu-map.ts +++ b/src/components/site-menu/site-menu-map.ts @@ -25,7 +25,7 @@ export default { 'Theming': { 'Basics': '/docs/theming/basics', 'Theming with CSS': '/docs/theming/theming-with-css', - 'Theming with Scss': '/docs/theming/theming-with-scss' + 'Theming with Sass': '/docs/theming/theming-with-sass' }, 'Contributing': {}, 'FAQ': {} diff --git a/src/docs-content/theming/basics.md b/src/docs-content/theming/basics.md index e7bec8c0c70..88071a94049 100755 --- a/src/docs-content/theming/basics.md +++ b/src/docs-content/theming/basics.md @@ -1,5 +1,5 @@ # Theming Basics -Ionic components can be themed at runtime using CSS properties. For more advanced theming, check out the **Theming with Scss** section of this guide. For a more in depth look at CSS theming, head over to the **Theming with CSS** section. To change the look of your application you can simply set any CSS properties you would like to change. Currently, Ionic's runtime theming is restricted to color changes. For layout changes you will need to dive into Scss theming. To begin, lets talk about the basic color concepts. +Ionic components can be themed at runtime using CSS properties. For more advanced theming, check out the **Theming with Sass** section of this guide. For a more in depth look at CSS theming, head over to the **Theming with CSS** section. To change the look of your application you can simply set any CSS properties you would like to change. Currently, Ionic's runtime theming is restricted to color changes. For layout changes you will need to dive into Sass theming. To begin, lets talk about the basic color concepts. #### The Color Map ``` diff --git a/src/docs-content/theming/theming-with-scss.md b/src/docs-content/theming/theming-with-sass.md similarity index 99% rename from src/docs-content/theming/theming-with-scss.md rename to src/docs-content/theming/theming-with-sass.md index c0b35216b51..2797cbbe385 100755 --- a/src/docs-content/theming/theming-with-scss.md +++ b/src/docs-content/theming/theming-with-sass.md @@ -1,4 +1,4 @@ -# Theming with Scss +# Theming with Sass SASS based theming allows for total control over the CSS generated for all of the Ionic Components; however, this requires a build step. CSS generated will still have CSS properties in them and it is recommended that these variables are not changed to allow your applications to use other themes easily. However, in the case of a completely custom application that requires no runtime theming, all the SASS is available for customization. ## Colors From 0954d5ebdcf4a8e8577c773e92696138a07489b9 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Thu, 8 Mar 2018 15:55:48 -0500 Subject: [PATCH 2/2] docs(theming): capitalize Sass --- src/docs-content/theming/theming-with-sass.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/docs-content/theming/theming-with-sass.md b/src/docs-content/theming/theming-with-sass.md index 2797cbbe385..1b710f89019 100755 --- a/src/docs-content/theming/theming-with-sass.md +++ b/src/docs-content/theming/theming-with-sass.md @@ -1,8 +1,8 @@ # Theming with Sass -SASS based theming allows for total control over the CSS generated for all of the Ionic Components; however, this requires a build step. CSS generated will still have CSS properties in them and it is recommended that these variables are not changed to allow your applications to use other themes easily. However, in the case of a completely custom application that requires no runtime theming, all the SASS is available for customization. +Sass based theming allows for total control over the CSS generated for all of the Ionic Components; however, this requires a build step. CSS generated will still have CSS properties in them and it is recommended that these variables are not changed to allow your applications to use other themes easily. However, in the case of a completely custom application that requires no runtime theming, all the Sass is available for customization. ## Colors -SASS variable theming concepts are very similar to that of CSS properties. In its simplest form, a custom theme can be generated by changing colors in the color map. Since most components use the primary color, this is the fastest way to get a custom look. +Sass variable theming concepts are very similar to that of CSS properties. In its simplest form, a custom theme can be generated by changing colors in the color map. Since most components use the primary color, this is the fastest way to get a custom look. ```sass $colors: (