fixup! [New] add jsx-props-no-spread-multi

Author: Simon Schick

README.md

@@ -338,7 +338,7 @@ module.exports = [
 | [jsx-one-expression-per-line](docs/rules/jsx-one-expression-per-line.md)                     | Require one JSX element per line                                                                                                             |    |    | 🔧 |    |    |
 | [jsx-pascal-case](docs/rules/jsx-pascal-case.md)                                             | Enforce PascalCase for user-defined JSX components                                                                                           |    |    |    |    |    |
 | [jsx-props-no-multi-spaces](docs/rules/jsx-props-no-multi-spaces.md)                         | Disallow multiple spaces between inline JSX props                                                                                            |    |    | 🔧 |    |    |
-| [jsx-props-no-spread-multi](docs/rules/jsx-props-no-spread-multi.md)                         | Disallow JSX prop spreading the same expression multiple times                                                                               |    |    |    |    |    |
+| [jsx-props-no-spread-multi](docs/rules/jsx-props-no-spread-multi.md)                         | Disallow JSX prop spreading the same identifier multiple times                                                                               |    |    |    |    |    |
 | [jsx-props-no-spreading](docs/rules/jsx-props-no-spreading.md)                               | Disallow JSX prop spreading                                                                                                                  |    |    |    |    |    |
 | [jsx-sort-default-props](docs/rules/jsx-sort-default-props.md)                               | Enforce defaultProps declarations alphabetical sorting                                                                                       |    |    |    |    | ❌  |
 | [jsx-sort-props](docs/rules/jsx-sort-props.md)                                               | Enforce props alphabetical sorting                                                                                                           |    |    | 🔧 |    |    |

docs/rules/jsx-props-no-spread-multi.md

@@ -1,4 +1,4 @@
-# Disallow JSX prop spreading the same expression multiple times (`react/jsx-props-no-spread-multi`)
+# Disallow JSX prop spreading the same identifier multiple times (`react/jsx-props-no-spread-multi`)
 
 <!-- end auto-generated rule header -->
 

lib/rules/jsx-props-no-spread-multi.js

@@ -16,21 +16,10 @@ const messages = {
   noMultiSpreading: 'Spreading the same expression multiple times is forbidden',
 };
 
-const ignoredAstProperties = new Set(['parent', 'range', 'loc', 'start', 'end', '_babelType']);
-
-/**
- * Filter for JSON.stringify that omits circular and position structures.
- *
- * @param {string} key
- * @param {*} value
- * @returns {*}
- */
-const propertyFilter = (key, value) => (ignoredAstProperties.has(key) ? undefined : value);
-
 module.exports = {
   meta: {
     docs: {
-      description: 'Disallow JSX prop spreading the same expression multiple times',
+      description: 'Disallow JSX prop spreading the same identifier multiple times',
       category: 'Best Practices',
       recommended: false,
       url: docsUrl('jsx-props-no-spread-multi'),
@@ -41,21 +30,22 @@ module.exports = {
   create(context) {
     return {
       JSXOpeningElement(node) {
-        const spreads = node.attributes.filter((attr) => attr.type === 'JSXSpreadAttribute');
+        const spreads = node.attributes.filter(
+          (attr) => attr.type === 'JSXSpreadAttribute' &&
+          attr.argument.type === 'Identifier'
+        );
         if (spreads.length < 2) {
           return;
         }
-        // We detect duplicate expressions by hashing the ast nodes
-        const argumentHashes = new Set();
+        // We detect duplicate expressions by their identifier
+        const identifierNames = new Set();
         for (const spread of spreads) {
-          // TODO: Deep compare ast function?
-          const hash = JSON.stringify(spread.argument, propertyFilter);
-          if (argumentHashes.has(hash)) {
+          if (identifierNames.has(spread.attr.name)) {
             report(context, messages.noMultiSpreading, 'noMultiSpreading', {
               node: spread,
             });
           }
-          argumentHashes.add(hash);
+          identifierNames.add(spread.attr.name);
         }
       },
     };

tests/lib/rules/jsx-props-no-spread-multi.js

@@ -66,13 +66,6 @@ ruleTester.run('jsx-props-no-spread-multi', rule, {
         <div {...props} {...props} {...props} />
       `,
       errors: [expectedError, expectedError],
-    },
-    {
-      code: `
-        const func = () => ({});
-        <div {...func()} {...func()}  />
-      `,
-      errors: [expectedError],
-    },
+    }
   ]),
 });