Skip to content

Commit 30cfc3b

Browse files
committed
Polishing
1 parent 0af9910 commit 30cfc3b

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTestExtension.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,10 @@ protected static Stream<? extends Arguments> arguments(ArgumentsProvider provide
150150
}
151151

152152
private Object[] consumedArguments(Object[] arguments, ParameterizedTestMethodContext methodContext) {
153-
int parameterCount = methodContext.getParameterCount();
154153
if (methodContext.hasAggregator()) {
155154
return arguments;
156155
}
156+
int parameterCount = methodContext.getParameterCount();
157157
return arguments.length > parameterCount ? Arrays.copyOf(arguments, parameterCount) : arguments;
158158
}
159159

junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/MethodArgumentsProvider.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ private static boolean looksLikeAFullyQualifiedMethodName(String factoryMethodNa
7373
if (factoryMethodName.contains("#")) {
7474
return true;
7575
}
76-
int indexOfDot = factoryMethodName.indexOf(".");
77-
if (indexOfDot == -1) {
76+
int indexOfFirstDot = factoryMethodName.indexOf('.');
77+
if (indexOfFirstDot == -1) {
7878
return false;
7979
}
80-
int indexOfOpeningParenthesis = factoryMethodName.indexOf("(");
81-
if (indexOfOpeningParenthesis > 0) {
82-
// Exclude simple method names with parameters
83-
return indexOfDot < indexOfOpeningParenthesis;
80+
int indexOfLastOpeningParenthesis = factoryMethodName.lastIndexOf('(');
81+
if (indexOfLastOpeningParenthesis > 0) {
82+
// Exclude simple/local method names with parameters
83+
return indexOfFirstDot < indexOfLastOpeningParenthesis;
8484
}
8585
// If we get this far, we conclude the supplied factory method name "looks"
8686
// like it was intended to be a fully qualified method name, even if the

0 commit comments

Comments
 (0)