Merge pull request #2574 from nirs/background-fix

Run in a new process group when not using --foreground

Author: AkihiroSuda

pkg/instance/ha_cmd_opts_others.go

@@ -6,4 +6,7 @@ import (
 	"syscall"
 )
 
-var SysProcAttr = &syscall.SysProcAttr{}
+var (
+	ForegroundSysProcAttr = &syscall.SysProcAttr{}
+	BackgroundSysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+)

pkg/instance/ha_cmd_opts_windows.go

@@ -4,6 +4,9 @@ import (
 	"syscall"
 )
 
-var SysProcAttr = &syscall.SysProcAttr{
-	CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP,
-}
+var (
+	ForegroundSysProcAttr = &syscall.SysProcAttr{}
+	BackgroundSysProcAttr = &syscall.SysProcAttr{
+		CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP,
+	}
+)

pkg/instance/start.go

@@ -189,7 +189,12 @@ func Start(ctx context.Context, inst *store.Instance, launchHostAgentForeground
 	}
 	args = append(args, inst.Name)
 	haCmd := exec.CommandContext(ctx, self, args...)
-	haCmd.SysProcAttr = SysProcAttr
+
+	if launchHostAgentForeground {
+		haCmd.SysProcAttr = ForegroundSysProcAttr
+	} else {
+		haCmd.SysProcAttr = BackgroundSysProcAttr
+	}
 
 	haCmd.Stdout = haStdoutW
 	haCmd.Stderr = haStderrW