Skip to content

Commit 7380c0d

Browse files
committed
Remove references to COVERAGE_AND_ORIGIN option
1 parent 84054b5 commit 7380c0d

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

llvm/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -537,8 +537,8 @@ endif()
537537
option(LLVM_ENABLE_CRASH_DUMPS "Turn on memory dumps on crashes. Currently only implemented on Windows." OFF)
538538

539539
set(LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING "DISABLED" CACHE STRING
540-
"Enhance Debugify's line number coverage tracking; enabling this is ABI-breaking. Can be DISABLED, COVERAGE, or COVERAGE_AND_ORIGIN.")
541-
set_property(CACHE LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING PROPERTY STRINGS DISABLED COVERAGE COVERAGE_AND_ORIGIN)
540+
"Enhance Debugify's line number coverage tracking; enabling this is ABI-breaking. Can be DISABLED, or COVERAGE.")
541+
set_property(CACHE LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING PROPERTY STRINGS DISABLED COVERAGE)
542542

543543
set(WINDOWS_PREFER_FORWARD_SLASH_DEFAULT OFF)
544544
if (MINGW)

llvm/cmake/modules/HandleLLVMOptions.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,6 @@ string(TOUPPER "${LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING}" uppercase_LLVM_ENABLE
200200

201201
if( uppercase_LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING STREQUAL "COVERAGE" )
202202
set( ENABLE_DEBUGLOC_COVERAGE_TRACKING 1 )
203-
elseif( uppercase_LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING STREQUAL "COVERAGE_AND_ORIGIN" )
204-
message(FATAL_ERROR "\"COVERAGE_AND_ORIGIN\" setting for LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING currently unimplemented.")
205203
elseif( uppercase_LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING STREQUAL "DISABLED" OR NOT DEFINED LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING )
206204
# The DISABLED setting is default and requires no additional defines.
207205
else()

llvm/docs/CMake.rst

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -483,14 +483,11 @@ enabled sub-projects. Nearly all of these variable names begin with
483483
**LLVM_ENABLE_DEBUGLOC_COVERAGE_TRACKING**:STRING
484484
Enhances Debugify's ability to detect line number errors by storing extra
485485
information inside Instructions, removing false positives from Debugify's
486-
results at the cost of performance. Allowed values are `DISABLED` (default),
487-
`COVERAGE`, and `COVERAGE_AND_ORIGIN`. `COVERAGE` tracks whether and why a
488-
line number was intentionally dropped or not generated for an instruction,
489-
allowing Debugify to avoid reporting these as errors; this comes with a small
490-
performance cost of ~0.1%. `COVERAGE_AND_ORIGIN` additionally stores a stack
491-
trace of the point where each DebugLoc is unintentionally dropped, allowing
492-
for much easier bug triaging at the cost of a ~10x performance slowdown.
493-
`COVERAGE` and `COVERAGE_AND_ORIGIN` are both ABI-breaking options.
486+
results at the cost of performance. Allowed values are `DISABLED` (default)
487+
and `COVERAGE`. `COVERAGE` tracks whether and why a line number was
488+
intentionally dropped or not generated for an instruction, allowing Debugify
489+
to avoid reporting these as errors; this comes with a small performance cost
490+
of ~0.1%. `COVERAGE` is an ABI-breaking option.
494491

495492
**LLVM_ENABLE_DIA_SDK**:BOOL
496493
Enable building with MSVC DIA SDK for PDB debugging support. Available

0 commit comments

Comments
 (0)