Reaplce goToDefinitionName with baselineGetDefinitionAtPosition

Author: sheetalkamat

src/harness/fourslashImpl.ts

@@ -2830,14 +2830,6 @@ export class TestState {
         this.goToPosition(pos);
     }
 
-    public verifyGoToDefinitionName(expectedName: string, expectedContainerName: string) {
-        const definitions = this.languageService.getDefinitionAtPosition(this.activeFile.fileName, this.currentCaretPosition);
-        const actualDefinitionName = definitions && definitions.length ? definitions[0].name : "";
-        const actualDefinitionContainerName = definitions && definitions.length ? definitions[0].containerName : "";
-        assert.equal(actualDefinitionName, expectedName, this.messageAtLastKnownMarker("Definition Info Name"));
-        assert.equal(actualDefinitionContainerName, expectedContainerName, this.messageAtLastKnownMarker("Definition Info Container Name"));
-    }
-
     public getMarkers(): Marker[] {
         //  Return a copy of the list
         return this.testData.markers.slice(0);

src/harness/fourslashInterfaceImpl.ts

@@ -310,10 +310,6 @@ export class Verify extends VerifyNegatable {
         this.state.verifyGoToDefinitionIs(endMarkers);
     }
 
-    public goToDefinitionName(name: string, containerName: string) {
-        this.state.verifyGoToDefinitionName(name, containerName);
-    }
-
     public verifyGetEmitOutputForCurrentFile(expected: string): void {
         this.state.verifyGetEmitOutputForCurrentFile(expected);
     }

tests/baselines/reference/definitionNameOnEnumMember.baseline.jsonc

@@ -0,0 +1,21 @@
+// === getDefinitionAtPosition ===
+// === /tests/cases/fourslash/definitionNameOnEnumMember.ts ===
+// enum e {
+//     firstMember,
+//     secondMember,
+//     [|thirdMember|]
+// }
+// var enumMember = e./*GOTO DEF POS*/thirdMember;
+
+  // === Details ===
+  [
+   {
+    "kind": "enum member",
+    "name": "thirdMember",
+    "containerName": "e",
+    "isLocal": true,
+    "isAmbient": false,
+    "unverified": false,
+    "failedAliasResolution": false
+   }
+  ]

tests/cases/fourslash/definitionNameOnEnumMember.ts

@@ -7,5 +7,4 @@
 ////}
 ////var enumMember = e.[|/*1*/thirdMember|];
 
-goTo.marker("1");
-verify.goToDefinitionName("thirdMember", "e");
+verify.baselineGetDefinitionAtPosition("1");

tests/cases/fourslash/fourslash.ts

@@ -312,7 +312,6 @@ declare namespace FourSlashInterface {
         formatDocumentChangesNothing(): void;
         /** Verifies that goToDefinition at the current position would take you to `endMarker`. */
         goToDefinitionIs(endMarkers: ArrayOrSingle<string>): void;
-        goToDefinitionName(name: string, containerName: string): void;
         verifyGetEmitOutputForCurrentFile(expected: string): void;
         verifyGetEmitOutputContentsForCurrentFile(expected: ts.OutputFile[]): void;
         baselineCommands(...commands: BaselineCommand[]): void;