Create separate cache when skipping function and object property augmentation

Author: sheetalkamat

src/compiler/checker.ts

@@ -10997,12 +10997,13 @@ namespace ts {
         // these partial properties when identifying discriminant properties, but otherwise they are filtered out
         // and do not appear to be present in the union type.
         function getUnionOrIntersectionProperty(type: UnionOrIntersectionType, name: __String, skipObjectFunctionPropertyAugment?: boolean): Symbol | undefined {
-            const properties = type.propertyCache || (type.propertyCache = createSymbolTable());
+            const properties = skipObjectFunctionPropertyAugment ?
+                type.propertyCacheWithoutObjectFunctionPropertyAugment ||= createSymbolTable() :
+                type.propertyCache ||= createSymbolTable();
             let property = properties.get(name);
             if (!property) {
                 property = createUnionOrIntersectionProperty(type, name, skipObjectFunctionPropertyAugment);
-                // Dont set the result since it might not be correct if skipping lookup from property of Object and function type
-                if (property && !skipObjectFunctionPropertyAugment) {
+                if (property) {
                     properties.set(name, property);
                 }
             }

src/compiler/types.ts

@@ -5140,7 +5140,9 @@ namespace ts {
         /* @internal */
         objectFlags: ObjectFlags;
         /* @internal */
-        propertyCache: SymbolTable;       // Cache of resolved properties
+        propertyCache?: SymbolTable;       // Cache of resolved properties
+        /* @internal */
+        propertyCacheWithoutObjectFunctionPropertyAugment?: SymbolTable; // Cache of resolved properties that does not augment function or object type properties
         /* @internal */
         resolvedProperties: Symbol[];
         /* @internal */