Widen SymbolConstructor unique symbol properties

Author: LukeAbby

internal/checker/checker.go

@@ -26,5 +26,5 @@ interface SymbolConstructor {
     readonly observer: unique symbol;
 }
 declare const obj: {
-    [x: symbol]: number;
+    [Symbol.observer]: number;
 };

testdata/baselines/reference/submodule/compiler/symbolObserverMismatchingPolyfillsWorkTogether.errors.txt

@@ -3,22 +3,22 @@
 === symbolObserverMismatchingPolyfillsWorkTogether.ts ===
 interface SymbolConstructor {
     readonly observer: symbol;
->observer : symbol
+>observer : unique symbol
 }
 interface SymbolConstructor {
     readonly observer: unique symbol;
->observer : symbol
+>observer : unique symbol
 }
 
 const obj = {
->obj : { [x: symbol]: number; }
->{    [Symbol.observer]: 0} : { [x: symbol]: number; }
+>obj : { [Symbol.observer]: number; }
+>{    [Symbol.observer]: 0} : { [Symbol.observer]: number; }
 
     [Symbol.observer]: 0
 >[Symbol.observer] : number
->Symbol.observer : symbol
+>Symbol.observer : unique symbol
 >Symbol : SymbolConstructor
->observer : symbol
+>observer : unique symbol
 >0 : 0
 
 };

testdata/baselines/reference/submodule/compiler/symbolObserverMismatchingPolyfillsWorkTogether.errors.txt.diff

@@ -58,9 +58,11 @@ declare global {
         readonly obs: symbol;
     }
 }
+declare const observable: typeof Symbol.obs;
 export declare class MyObservable<T> {
-    [x: symbol]: () => this;
     private _val;
     constructor(_val: T);
     subscribe(next: (val: T) => void): void;
+    [observable](): this;
 }
+export {};

testdata/baselines/reference/submodule/compiler/symbolObserverMismatchingPolyfillsWorkTogether.js

@@ -7,17 +7,4 @@
 +    _val;
      constructor(_val) {
          this._val = _val;
-     }
-@@= skipped -22, +23 lines =@@
-         readonly obs: symbol;
-     }
- }
--declare const observable: typeof Symbol.obs;
- export declare class MyObservable<T> {
-+    [x: symbol]: () => this;
-     private _val;
-     constructor(_val: T);
-     subscribe(next: (val: T) => void): void;
--    [observable](): this;
- }
--export {};
+     }

testdata/baselines/reference/submodule/compiler/symbolObserverMismatchingPolyfillsWorkTogether.js.diff

@@ -6,18 +6,18 @@ declare global {
 
   interface SymbolConstructor {
     readonly obs: symbol
->obs : symbol
+>obs : unique symbol
   }
 }
 
 const observable: typeof Symbol.obs = Symbol.obs
->observable : symbol
->Symbol.obs : symbol
+>observable : unique symbol
+>Symbol.obs : unique symbol
 >Symbol : SymbolConstructor
->obs : symbol
->Symbol.obs : symbol
+>obs : unique symbol
+>Symbol.obs : unique symbol
 >Symbol : SymbolConstructor
->obs : symbol
+>obs : unique symbol
 
 export class MyObservable<T> {
 >MyObservable : MyObservable<T>
@@ -40,7 +40,7 @@ export class MyObservable<T> {
 
     [observable]() {
 >[observable] : () => this
->observable : symbol
+>observable : unique symbol
 
         return this
 >this : this
@@ -52,9 +52,9 @@ type InteropObservable<T> = {
 
     [Symbol.obs]: () => { subscribe(next: (val: T) => void): void }
 >[Symbol.obs] : () => { subscribe(next: (val: T) => void): void; }
->Symbol.obs : symbol
+>Symbol.obs : unique symbol
 >Symbol : SymbolConstructor
->obs : symbol
+>obs : unique symbol
 >subscribe : (next: (val: T) => void) => void
 >next : (val: T) => void
 >val : T
@@ -68,9 +68,9 @@ function from<T>(obs: InteropObservable<T>) {
 >obs[Symbol.obs]() : { subscribe(next: (val: T) => void): void; }
 >obs[Symbol.obs] : () => { subscribe(next: (val: T) => void): void; }
 >obs : InteropObservable<T>
->Symbol.obs : symbol
+>Symbol.obs : unique symbol
 >Symbol : SymbolConstructor
->obs : symbol
+>obs : unique symbol
 }
 
 from(new MyObservable(42))