Skip to content

Commit e74712b

Browse files
committed
fixes #118731
1 parent 319d151 commit e74712b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/vs/platform/debug/electron-main/extensionHostDebugIpc.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,12 @@ export class ElectronExtensionHostDebugBroadcastChannel<TContext> extends Extens
5757
});
5858

5959
if (!debugRenderer) {
60-
return { success: false };
60+
return { success: true };
6161
}
6262

6363
const win = codeWindow.win;
6464
if (!win) {
65-
return { success: false };
65+
return { success: true };
6666
}
6767

6868
const debug = win.webContents.debugger;

src/vs/workbench/contrib/debug/browser/rawDebugSession.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ export class RawDebugSession implements IDisposable {
570570
try {
571571
let result = await this.launchVsCode(<ILaunchVSCodeArguments>request.arguments);
572572
if (!result.success) {
573-
const showResult = await this.dialogSerivce.show(Severity.Warning, nls.localize('canNotStart', "The debugger needs to open a new tab or window for the debuggee. Due to a security feature of the browser, you must give permission to allow this."), [nls.localize('contineInNewTab', "Continue in new tab"), nls.localize('cancel', "Cancel")]);
573+
const showResult = await this.dialogSerivce.show(Severity.Warning, nls.localize('canNotStart', "The debugger needs to open a new tab or window for the debuggee. Due to a security feature of the browser, you must give permission to allow this."), [nls.localize('continue', "Continue"), nls.localize('cancel', "Cancel")]);
574574
if (showResult.choice === 0) {
575575
result = await this.launchVsCode(<ILaunchVSCodeArguments>request.arguments);
576576
} else {

0 commit comments

Comments
 (0)