Skip to content

Commit f4f256d

Browse files
mircea-cosbucfealebenpae
authored andcommitted
Remove OM request time from Honeycomb span attributes (#3931)
# Summary As raised in this conversation: REDACTED We're close to hitting the limit on unique span attributes as Honeycomb indexes them and we generate new Org and Project IDs in every test run where we make OM requests. ## Documentation changes * [ ] Add an entry to [release notes](.../RELEASE_NOTES.md). * [ ] When needed, make sure you create a new [DOCSP ticket](https://jira.mongodb.org/projects/DOCSP) that documents your change. ## Changes to CRDs * [ ] Add `slaskawi`(Sebastian) and `@giohan` (George) as reviewers. * [ ] Make sure any changes are reflected on `/public/samples` directory.
1 parent 31c265b commit f4f256d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

docker/mongodb-enterprise-tests/kubetester/omtester.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,8 @@ def om_request():
379379
print("failed connecting to om")
380380
raise e
381381

382-
span.set_attribute(key=f"meko_om_request_path_{last_path_part}_time", value=time.time() - start_time)
382+
# Removing OM Request time from span attributes as Honeycomb indexes unique keys and we're limited to 1000
383+
# span.set_attribute(key=f"meko_om_request_path_{last_path_part}_time", value=time.time() - start_time)
383384

384385
if response.status_code >= 300:
385386
raise Exception(

0 commit comments

Comments
 (0)