Skip to content

Commit e0a2e9d

Browse files
committed
chore(NODE-3293): update denque and type parameter to resume queue
1 parent dd3794f commit e0a2e9d

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
},
3434
"dependencies": {
3535
"bson": "^4.5.1",
36-
"denque": "^1.5.0",
36+
"denque": "^2.0.1",
3737
"mongodb-connection-string-url": "^2.0.0"
3838
},
3939
"devDependencies": {

src/change_stream.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ export class ChangeStream<
210210
cursor?: ChangeStreamCursor<TSchema>;
211211
streamOptions?: CursorStreamOptions;
212212
/** @internal */
213-
[kResumeQueue]: Denque;
213+
[kResumeQueue]: Denque<Callback<ChangeStreamCursor<TSchema>>>;
214214
/** @internal */
215215
[kCursorStream]?: Readable;
216216
/** @internal */
@@ -809,6 +809,8 @@ function getCursor<T>(changeStream: ChangeStream<T>, callback: Callback<ChangeSt
809809
function processResumeQueue<TSchema>(changeStream: ChangeStream<TSchema>, err?: Error) {
810810
while (changeStream[kResumeQueue].length) {
811811
const request = changeStream[kResumeQueue].pop();
812+
if (!request) break; // Should never occur but TS can't use the length check in the while condition
813+
812814
if (!err) {
813815
if (changeStream[kClosed]) {
814816
// TODO(NODE-3485): Replace with MongoChangeStreamClosedError

0 commit comments

Comments
 (0)